| Message ID | 1524763162-4865-3-git-send-email-brad@nextdimension.cc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Brad! Tonight build broke due to patch 95ee4c285022! You enabled VIDEO_OV2685 for 3.13., which doesn't compile for Kernels older than 3.17. When you look to the Kernel 3.17 section a lot of the drivers you enabled for 3.13 with your patch should be enabled for 3.17 only. So please test this and provide a follow up patch. I will not revert 95ee4c285022 now, except you can't fix it in a reasonable time frame. If you like and you have time you can improve scripts/make_kconfig.pl to detect such an issue to avoid future problems like this. I also had such a situation with enabling a driver twice in the past. BR, Jasmin
Hi Jasmin, On 2018-05-12 04:31, Jasmin J. wrote: > Hello Brad! > > Tonight build broke due to patch 95ee4c285022! > You enabled VIDEO_OV2685 for 3.13., which doesn't > compile for Kernels older than 3.17. When you look > to the Kernel 3.17 section a lot of the drivers you > enabled for 3.13 with your patch should be enabled > for 3.17 only. > > So please test this and provide a follow up patch. > I will not revert 95ee4c285022 now, except you can't > fix it in a reasonable time frame. > > If you like and you have time you can improve > scripts/make_kconfig.pl to detect such an issue to > avoid future problems like this. I also had such a > situation with enabling a driver twice in the past. > > BR, > Jasmin Apologies. Interesting though, as I was working against 3.10 while submitting this. I will verify and submit a correction today. Cheers, Brad
Hi Jasmin, On 2018-05-12 08:20, Brad Love wrote: > Hi Jasmin, > > > On 2018-05-12 04:31, Jasmin J. wrote: >> Hello Brad! >> >> Tonight build broke due to patch 95ee4c285022! >> You enabled VIDEO_OV2685 for 3.13., which doesn't >> compile for Kernels older than 3.17. When you look >> to the Kernel 3.17 section a lot of the drivers you >> enabled for 3.13 with your patch should be enabled >> for 3.17 only. >> >> So please test this and provide a follow up patch. >> I will not revert 95ee4c285022 now, except you can't >> fix it in a reasonable time frame. >> >> If you like and you have time you can improve >> scripts/make_kconfig.pl to detect such an issue to >> avoid future problems like this. I also had such a >> situation with enabling a driver twice in the past. >> >> BR, >> Jasmin > Apologies. Interesting though, as I was working against 3.10 while > submitting this. I will verify and submit a correction today. > > Cheers, > > Brad Looks like the media_build environment on the system I made this patch for was a little older, pretty much from right before you added all the affected drivers to 3.17.0. Bad on me for not noticing. I submitted a fixup for that and also moved the other drivers from the patch to 3.17.0 as well. Should compile again for you. Cheers, Brad
Hello Brad! THX for the quick fix! Hans did already apply it and Kernel 3.16 builds now. I hope we will see a complete build tomorrow. BR, Jasmin
diff --git a/v4l/versions.txt b/v4l/versions.txt index ae0731d..2306830 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -107,6 +107,15 @@ VIDEO_VIM2M [3.13.0] # needs gpio/consumer.h RADIO_SI4713 +VIDEO_OV2685 +VIDEO_OV5695 +VIDEO_OV9650 +VIDEO_MT9T112 +SOC_CAMERA_MT9T112 +VIDEO_OV772X +SOC_CAMERA_OV772X +VIDEO_TW9910 +SOC_CAMERA_TW9910 [3.12.0] # BIN_ATTR_RW was changed @@ -221,7 +230,6 @@ SOC_CAMERA SOC_CAMERA_MT9V022 SOC_CAMERA_MT9M001 SOC_CAMERA_MT9T031 -SOC_CAMERA_OV772X SOC_CAMERA_PLATFORM # Needs of_match_ptr VIDEO_THS8200
One driver migrated to 3.13 from 3.5 Signed-off-by: Brad Love <brad@nextdimension.cc> --- v4l/versions.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)