| Message ID | 1526009672-2097-1-git-send-email-zhangqing@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Elaine, Am Freitag, 11. Mai 2018, 05:34:32 CEST schrieb Elaine Zhang: > According to a description from TRM, add all the power domains. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> that's a bit ambigous, having the Signed-offs like above. Either you are the author+sender of the patch, then Finley's Signed-off should go away ... or Finley is the author and you are the sender, then the author of the patch should be set correctly (--author option for git) and the Signed-offs should switch places (= Finley first, then yours). Please fix. This seems to be true for most patches in this series. > --- > include/dt-bindings/power/px30-power.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 include/dt-bindings/power/px30-power.h > > diff --git a/include/dt-bindings/power/px30-power.h b/include/dt-bindings/power/px30-power.h > new file mode 100644 > index 000000000000..4ed482e80950 > --- /dev/null > +++ b/include/dt-bindings/power/px30-power.h Here I have a naming question. When looking at the vendor kernel it looks like the px30 is largely related to the rk3326. (rk3326.dtsi includeing the px30.dtsi) What is the reason for basing the naming on the px30 this time? And could we possibly keep to rkXXXX names for the basic things in the kernel, thus keeping the pxXX as second name, like with the other px-variants before? Thanks Heiko
Hi Heiko: On 2018年05月12日 06:11, Heiko Stuebner wrote: > Here I have a naming question. When looking at the vendor kernel > it looks like the px30 is largely related to the rk3326. > (rk3326.dtsi includeing the px30.dtsi) > > What is the reason for basing the naming on the px30 this time? And could > we possibly keep to rkXXXX names for the basic things in the kernel, thus > keeping the pxXX as second name, like with the other px-variants before? > PX30 and RK3326 are different chips. PX30 has more features. You can simply think that RK3326 is a subset of PX30. The RK3326 is more like a PX30 derivative chip. This is not the same as the previous chips. So we use PX30 instead of RK3326 for name, and the opening document is only for PX30, we think this is more convenient for developers. Best Regards, Tao Huang
Hi, Am Sonntag, 13. Mai 2018, 17:18:12 CEST schrieb Tao Huang: > Hi Heiko: > > On 2018年05月12日 06:11, Heiko Stuebner wrote: > > Here I have a naming question. When looking at the vendor kernel > > it looks like the px30 is largely related to the rk3326. > > (rk3326.dtsi includeing the px30.dtsi) > > > > What is the reason for basing the naming on the px30 this time? And could > > we possibly keep to rkXXXX names for the basic things in the kernel, thus > > keeping the pxXX as second name, like with the other px-variants before? > > PX30 and RK3326 are different chips. PX30 has more features. You can simply > think that RK3326 is a subset of PX30. The RK3326 is more like a PX30 > derivative chip. This is not the same as the previous chips. So we use PX30 > instead of RK3326 for name, and the opening document is only for PX30, we > think this is more convenient for developers. ok, sounds reasonable :-) ... So we'll stay with the PX30. Heiko
diff --git a/include/dt-bindings/power/px30-power.h b/include/dt-bindings/power/px30-power.h new file mode 100644 index 000000000000..4ed482e80950 --- /dev/null +++ b/include/dt-bindings/power/px30-power.h @@ -0,0 +1,32 @@ +/* + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd + * + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) + */ + +#ifndef __DT_BINDINGS_POWER_PX30_POWER_H__ +#define __DT_BINDINGS_POWER_PX30_POWER_H__ + +/* VD_CORE */ +#define PX30_PD_A35_0 0 +#define PX30_PD_A35_1 1 +#define PX30_PD_A35_2 2 +#define PX30_PD_A35_3 3 +#define PX30_PD_SCU 4 + +/* VD_LOGIC */ +#define PX30_PD_USB 5 +#define PX30_PD_DDR 6 +#define PX30_PD_SDCARD 7 +#define PX30_PD_CRYPTO 8 +#define PX30_PD_GMAC 9 +#define PX30_PD_MMC_NAND 10 +#define PX30_PD_VPU 11 +#define PX30_PD_VO 12 +#define PX30_PD_VI 13 +#define PX30_PD_GPU 14 + +/* VD_PMU */ +#define PX30_PD_PMU 15 + +#endif