diff mbox

builtin: Mark more regular built-ins

Message ID 20180515112729.w7kwpa7lczwginx3@gondor.apana.org.au (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show

Commit Message

Herbert Xu May 15, 2018, 11:27 a.m. UTC
This patch marks the following built-ins as regular, meaning that
they cannot be overriden using PATH search:

	hash
	pwd
	type
	ulimit

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Jilles Tjoelker May 15, 2018, 9:40 p.m. UTC | #1
On Tue, May 15, 2018 at 07:27:29PM +0800, Herbert Xu wrote:
> This patch marks the following built-ins as regular, meaning that
> they cannot be overriden using PATH search:

> 	hash
> 	pwd
> 	type
> 	ulimit

This seems correct, but lacks rationale. The rationale is that pwd
should have been here since long ago (because it is in the list in XCU
2.9.1.1 Command Search and Execution), while the other three are new in
SUSv4tc2.
diff mbox

Patch

diff --git a/src/builtins.def.in b/src/builtins.def.in
index 4441fe4..95e420c 100644
--- a/src/builtins.def.in
+++ b/src/builtins.def.in
@@ -69,11 +69,11 @@  exitcmd		-s exit
 exportcmd	-as export -as readonly
 falsecmd	-u false
 getoptscmd	-u getopts
-hashcmd		hash
+hashcmd		-u hash
 jobscmd		-u jobs
 localcmd	-as local
 printfcmd	printf
-pwdcmd		pwd
+pwdcmd		-u pwd
 readcmd		-u read
 returncmd	-s return
 setcmd		-s set
@@ -81,14 +81,14 @@  shiftcmd	-s shift
 timescmd	-s times
 trapcmd		-s trap
 truecmd		-s : -u true
-typecmd		type
+typecmd		-u type
 umaskcmd	-u umask
 unaliascmd	-u unalias
 unsetcmd	-s unset
 waitcmd		-u wait
 aliascmd	-au alias
 #ifdef HAVE_GETRLIMIT
-ulimitcmd	ulimit
+ulimitcmd	-u ulimit
 #endif
 testcmd		test [
 killcmd		-u kill