| Message ID | 20180522084058.66520-1-colyli@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2018-05-22 at 16:40 +0800, Coly Li wrote: > This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a > compiling > warninng. I have no opinion about this. Code has a top description from which it has been taken / derived, so, I dunno if GPL is what it really is. In any case it's probably worth to add SPDX header as well. > > Signed-off-by: Coly Li <colyli@suse.de> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > lib/crc64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/crc64.c b/lib/crc64.c > index ed0ffac7b26a..586e46684ee8 100644 > --- a/lib/crc64.c > +++ b/lib/crc64.c > @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len) > EXPORT_SYMBOL_GPL(crc64); > > MODULE_DESCRIPTION("CRC64 calculations"); > +MODULE_LICENSE("GPL");
On 2018/5/22 4:43 PM, Andy Shevchenko wrote: > On Tue, 2018-05-22 at 16:40 +0800, Coly Li wrote: >> This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a >> compiling >> warninng. > > I have no opinion about this. Code has a top description from which it > has been taken / derived, so, I dunno if GPL is what it really is. > > In any case it's probably worth to add SPDX header as well. > Hmm, there is a warning complains no MODULE_LICENSE() in lib/crc64.c, when I compile a kernel for testing. The purpose is just to kill a compiler warning. And sure, I will post an update version with SPDX header. Thanks for the hint :-) Coly Li >> >> Signed-off-by: Coly Li <colyli@suse.de> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> --- >> lib/crc64.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/crc64.c b/lib/crc64.c >> index ed0ffac7b26a..586e46684ee8 100644 >> --- a/lib/crc64.c >> +++ b/lib/crc64.c >> @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len) >> EXPORT_SYMBOL_GPL(crc64); >> >> MODULE_DESCRIPTION("CRC64 calculations"); >> +MODULE_LICENSE("GPL"); >
diff --git a/lib/crc64.c b/lib/crc64.c index ed0ffac7b26a..586e46684ee8 100644 --- a/lib/crc64.c +++ b/lib/crc64.c @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len) EXPORT_SYMBOL_GPL(crc64); MODULE_DESCRIPTION("CRC64 calculations"); +MODULE_LICENSE("GPL");
This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a compiling warninng. Signed-off-by: Coly Li <colyli@suse.de> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- lib/crc64.c | 1 + 1 file changed, 1 insertion(+)