| Message ID | 20180522083728.5874-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 22/05/2018 11:37 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trivial fix to spelling mistake in mlx4_dbg debug message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c b/drivers/net/ethernet/mellanox/mlx4/intf.c > index 2edcce98ab2d..6bd4103265d2 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/intf.c > +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c > @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable) > list_add_tail(&dev_ctx->list, &priv->ctx_list); > spin_unlock_irqrestore(&priv->ctx_lock, flags); > > - mlx4_dbg(dev, "Inrerface for protocol %d restarted with when bonded mode is %s\n", > + mlx4_dbg(dev, "Interface for protocol %d restarted with when bonded mode is %s\n", Thanks Colin. I think there's one more thing to fix here. It is redundant to say "with when", it was probably done by mistake. Let's rephrase, maybe this way? restarted with bonded mode %s > dev_ctx->intf->protocol, enable ? > "enabled" : "disabled"); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22/05/18 16:21, Tariq Toukan wrote: > > > On 22/05/2018 11:37 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Trivial fix to spelling mistake in mlx4_dbg debug message >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c >> b/drivers/net/ethernet/mellanox/mlx4/intf.c >> index 2edcce98ab2d..6bd4103265d2 100644 >> --- a/drivers/net/ethernet/mellanox/mlx4/intf.c >> +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c >> @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable) >> list_add_tail(&dev_ctx->list, &priv->ctx_list); >> spin_unlock_irqrestore(&priv->ctx_lock, flags); >> - mlx4_dbg(dev, "Inrerface for protocol %d restarted with >> when bonded mode is %s\n", >> + mlx4_dbg(dev, "Interface for protocol %d restarted with when >> bonded mode is %s\n", > > Thanks Colin. > I think there's one more thing to fix here. > It is redundant to say "with when", it was probably done by mistake. > Let's rephrase, maybe this way? > > restarted with bonded mode %s Sounds like a good idea, do you want me to send V2 of the patch with this fix? > >> dev_ctx->intf->protocol, enable ? >> "enabled" : "disabled"); >> } >> > > -- > To unsubscribe from this list: send the line "unsubscribe > kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22/05/2018 6:23 PM, Colin Ian King wrote: > On 22/05/18 16:21, Tariq Toukan wrote: >> >> >> On 22/05/2018 11:37 AM, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> Trivial fix to spelling mistake in mlx4_dbg debug message >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c >>> b/drivers/net/ethernet/mellanox/mlx4/intf.c >>> index 2edcce98ab2d..6bd4103265d2 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx4/intf.c >>> +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c >>> @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable) >>> list_add_tail(&dev_ctx->list, &priv->ctx_list); >>> spin_unlock_irqrestore(&priv->ctx_lock, flags); >>> - mlx4_dbg(dev, "Inrerface for protocol %d restarted with >>> when bonded mode is %s\n", >>> + mlx4_dbg(dev, "Interface for protocol %d restarted with when >>> bonded mode is %s\n", >> >> Thanks Colin. >> I think there's one more thing to fix here. >> It is redundant to say "with when", it was probably done by mistake. >> Let's rephrase, maybe this way? >> >> restarted with bonded mode %s > > Sounds like a good idea, do you want me to send V2 of the patch with > this fix? > Yes please. >> >>> dev_ctx->intf->protocol, enable ? >>> "enabled" : "disabled"); >>> } >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> kernel-janitors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c b/drivers/net/ethernet/mellanox/mlx4/intf.c index 2edcce98ab2d..6bd4103265d2 100644 --- a/drivers/net/ethernet/mellanox/mlx4/intf.c +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable) list_add_tail(&dev_ctx->list, &priv->ctx_list); spin_unlock_irqrestore(&priv->ctx_lock, flags); - mlx4_dbg(dev, "Inrerface for protocol %d restarted with when bonded mode is %s\n", + mlx4_dbg(dev, "Interface for protocol %d restarted with when bonded mode is %s\n", dev_ctx->intf->protocol, enable ? "enabled" : "disabled"); }