| Message ID | 20180523182404.11433-2-david@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, May 23, 2018 at 8:24 PM, David Hildenbrand <david@redhat.com> wrote: > Will be needed by paravirtualized memory devices. That's a little information. It would be good to see the entire series at least. > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-acpi@vger.kernel.org > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > drivers/acpi/numa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c > index 85167603b9c9..7ffee2959350 100644 > --- a/drivers/acpi/numa.c > +++ b/drivers/acpi/numa.c > @@ -50,6 +50,7 @@ int pxm_to_node(int pxm) > return NUMA_NO_NODE; > return pxm_to_node_map[pxm]; > } > +EXPORT_SYMBOL(pxm_to_node); EXPORT_SYMBOL_GPL(), please. > > int node_to_pxm(int node) > { > --
On 24.05.2018 10:12, Rafael J. Wysocki wrote: > On Wed, May 23, 2018 at 8:24 PM, David Hildenbrand <david@redhat.com> wrote: >> Will be needed by paravirtualized memory devices. > > That's a little information. > > It would be good to see the entire series at least. It's part of this series (guess you only received the cover letter and this patch). Here a link to the patch using it: https://lkml.org/lkml/2018/5/23/803 > >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Len Brown <lenb@kernel.org> >> Cc: linux-acpi@vger.kernel.org >> Signed-off-by: David Hildenbrand <david@redhat.com> >> --- >> drivers/acpi/numa.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c >> index 85167603b9c9..7ffee2959350 100644 >> --- a/drivers/acpi/numa.c >> +++ b/drivers/acpi/numa.c >> @@ -50,6 +50,7 @@ int pxm_to_node(int pxm) >> return NUMA_NO_NODE; >> return pxm_to_node_map[pxm]; >> } >> +EXPORT_SYMBOL(pxm_to_node); > > EXPORT_SYMBOL_GPL(), please. Yes, will do, thanks! > >> >> int node_to_pxm(int node) >> { >> --
On Thu, May 24, 2018 at 10:33 AM, David Hildenbrand <david@redhat.com> wrote: > On 24.05.2018 10:12, Rafael J. Wysocki wrote: >> On Wed, May 23, 2018 at 8:24 PM, David Hildenbrand <david@redhat.com> wrote: >>> Will be needed by paravirtualized memory devices. >> >> That's a little information. >> >> It would be good to see the entire series at least. > > It's part of this series (guess you only received the cover letter and > this patch). Here a link to the patch using it: > > https://lkml.org/lkml/2018/5/23/803 OK, thanks! It looks like you have a reason to use it in there, but please note that CONFIG_ACPI_NUMA depends on CONFIG_NUMA, so you don't need to use the latter directly in the #ifdef. Also wouldn't IS_ENABLED() work there? Moreover, you don't need the local node variable in virtio_mem_translate_node_id().
On 24.05.2018 10:47, Rafael J. Wysocki wrote: > On Thu, May 24, 2018 at 10:33 AM, David Hildenbrand <david@redhat.com> wrote: >> On 24.05.2018 10:12, Rafael J. Wysocki wrote: >>> On Wed, May 23, 2018 at 8:24 PM, David Hildenbrand <david@redhat.com> wrote: >>>> Will be needed by paravirtualized memory devices. >>> >>> That's a little information. >>> >>> It would be good to see the entire series at least. >> >> It's part of this series (guess you only received the cover letter and >> this patch). Here a link to the patch using it: >> >> https://lkml.org/lkml/2018/5/23/803 > > OK, thanks! > > It looks like you have a reason to use it in there, but please note > that CONFIG_ACPI_NUMA depends on CONFIG_NUMA, so you don't need to use > the latter directly in the #ifdef. Also wouldn't IS_ENABLED() work > there? Thanks for the tip on CONFIG_ACPI_NUMA. Wouldn't IS_ENABLED() require to have a dummy implementation of pxm_to_node() in case drivers/acpi/numa.c is not compiled? > > Moreover, you don't need the local node variable in > virtio_mem_translate_node_id(). > Indeed, thanks!
On Thu, May 24, 2018 at 10:54 AM, David Hildenbrand <david@redhat.com> wrote: > On 24.05.2018 10:47, Rafael J. Wysocki wrote: >> On Thu, May 24, 2018 at 10:33 AM, David Hildenbrand <david@redhat.com> wrote: >>> On 24.05.2018 10:12, Rafael J. Wysocki wrote: >>>> On Wed, May 23, 2018 at 8:24 PM, David Hildenbrand <david@redhat.com> wrote: >>>>> Will be needed by paravirtualized memory devices. >>>> >>>> That's a little information. >>>> >>>> It would be good to see the entire series at least. >>> >>> It's part of this series (guess you only received the cover letter and >>> this patch). Here a link to the patch using it: >>> >>> https://lkml.org/lkml/2018/5/23/803 >> >> OK, thanks! >> >> It looks like you have a reason to use it in there, but please note >> that CONFIG_ACPI_NUMA depends on CONFIG_NUMA, so you don't need to use >> the latter directly in the #ifdef. Also wouldn't IS_ENABLED() work >> there? > > Thanks for the tip on CONFIG_ACPI_NUMA. Wouldn't IS_ENABLED() require to > have a dummy implementation of pxm_to_node() in case drivers/acpi/numa.c > is not compiled? Yes, it would. But since you want export it, you can very well add one, can't you? I'd even say that it would be prudent to do so.
On 24.05.2018 11:01, Rafael J. Wysocki wrote: > On Thu, May 24, 2018 at 10:54 AM, David Hildenbrand <david@redhat.com> wrote: >> On 24.05.2018 10:47, Rafael J. Wysocki wrote: >>> On Thu, May 24, 2018 at 10:33 AM, David Hildenbrand <david@redhat.com> wrote: >>>> On 24.05.2018 10:12, Rafael J. Wysocki wrote: >>>>> On Wed, May 23, 2018 at 8:24 PM, David Hildenbrand <david@redhat.com> wrote: >>>>>> Will be needed by paravirtualized memory devices. >>>>> >>>>> That's a little information. >>>>> >>>>> It would be good to see the entire series at least. >>>> >>>> It's part of this series (guess you only received the cover letter and >>>> this patch). Here a link to the patch using it: >>>> >>>> https://lkml.org/lkml/2018/5/23/803 >>> >>> OK, thanks! >>> >>> It looks like you have a reason to use it in there, but please note >>> that CONFIG_ACPI_NUMA depends on CONFIG_NUMA, so you don't need to use >>> the latter directly in the #ifdef. Also wouldn't IS_ENABLED() work >>> there? >> >> Thanks for the tip on CONFIG_ACPI_NUMA. Wouldn't IS_ENABLED() require to >> have a dummy implementation of pxm_to_node() in case drivers/acpi/numa.c >> is not compiled? > > Yes, it would. > > But since you want export it, you can very well add one, can't you? > I'd even say that it would be prudent to do so. > Sure, can do that :)
diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c index 85167603b9c9..7ffee2959350 100644 --- a/drivers/acpi/numa.c +++ b/drivers/acpi/numa.c @@ -50,6 +50,7 @@ int pxm_to_node(int pxm) return NUMA_NO_NODE; return pxm_to_node_map[pxm]; } +EXPORT_SYMBOL(pxm_to_node); int node_to_pxm(int node) {
Will be needed by paravirtualized memory devices. Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Len Brown <lenb@kernel.org> Cc: linux-acpi@vger.kernel.org Signed-off-by: David Hildenbrand <david@redhat.com> --- drivers/acpi/numa.c | 1 + 1 file changed, 1 insertion(+)