diff mbox

ARM: pxa3xx: enable external wakeup pins

Message ID 20180524204046.21494-1-daniel@zonque.org (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Mack May 24, 2018, 8:40 p.m. UTC
The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
have no alternate functions, so let's always enable them as wakeup source on
DT enabled boards. The WAKEUP1 pin is only available on PXA320.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 arch/arm/mach-pxa/pxa3xx.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Robert Jarzmik May 25, 2018, 8:22 p.m. UTC | #1
Daniel Mack <daniel@zonque.org> writes:

> The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
> have no alternate functions, so let's always enable them as wakeup source on
> DT enabled boards. The WAKEUP1 pin is only available on PXA320.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
That looks correct. Is it tested on any board ?

Cheers.

--
Robert
Daniel Mack May 25, 2018, 8:23 p.m. UTC | #2
On Friday, May 25, 2018 10:22 PM, Robert Jarzmik wrote:
> Daniel Mack <daniel@zonque.org> writes:
> 
>> The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
>> have no alternate functions, so let's always enable them as wakeup source on
>> DT enabled boards. The WAKEUP1 pin is only available on PXA320.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
> That looks correct. Is it tested on any board ?

Yup, on a PXA303 based one.


Thanks,
Daniel
Robert Jarzmik May 25, 2018, 8:41 p.m. UTC | #3
Daniel Mack <daniel@zonque.org> writes:

> On Friday, May 25, 2018 10:22 PM, Robert Jarzmik wrote:
>> Daniel Mack <daniel@zonque.org> writes:
>>
>>> The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins
>>> have no alternate functions, so let's always enable them as wakeup source on
>>> DT enabled boards. The WAKEUP1 pin is only available on PXA320.
>>>
>>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> That looks correct. Is it tested on any board ?
>
> Yup, on a PXA303 based one.
Great.

Queued into pxa/for-next.

Cheers.
diff mbox

Patch

diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
index 2a5044dd463e..9e05f92cd97a 100644
--- a/arch/arm/mach-pxa/pxa3xx.c
+++ b/arch/arm/mach-pxa/pxa3xx.c
@@ -442,6 +442,10 @@  static int __init pxa3xx_init(void)
 
 		pxa3xx_init_pm();
 
+		enable_irq_wake(IRQ_WAKEUP0);
+		if (cpu_is_pxa320())
+			enable_irq_wake(IRQ_WAKEUP1);
+
 		register_syscore_ops(&pxa_irq_syscore_ops);
 		register_syscore_ops(&pxa3xx_mfp_syscore_ops);