| Message ID | 20180529153107.12791-21-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> From: Greg Kroah-Hartman, Sent: Wednesday, May 30, 2018 12:31 AM > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Felipe Balbi <balbi@kernel.org> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- I tested on r8a7795-salvator-xs. So, Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 30, 2018 at 07:38:24AM +0000, Yoshihiro Shimoda wrote: > > From: Greg Kroah-Hartman, Sent: Wednesday, May 30, 2018 12:31 AM > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Cc: Felipe Balbi <balbi@kernel.org> > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Cc: Simon Horman <horms+renesas@verge.net.au> > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > I tested on r8a7795-salvator-xs. So, > > Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks for testing! greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 5caf78bbbf7c..977ea1a02cf9 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2391,22 +2391,10 @@ static const struct file_operations renesas_usb3_b_device_fops = { static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3, struct device *dev) { - struct dentry *root, *file; + usb3->dentry = debugfs_create_dir(dev_name(dev), NULL); - root = debugfs_create_dir(dev_name(dev), NULL); - if (IS_ERR_OR_NULL(root)) { - dev_info(dev, "%s: Can't create the root\n", __func__); - return; - } - - file = debugfs_create_file("b_device", 0644, root, usb3, - &renesas_usb3_b_device_fops); - if (!file) { - dev_info(dev, "%s: Can't create debugfs mode\n", __func__); - debugfs_remove_recursive(root); - } else { - usb3->dentry = root; - } + debugfs_create_file("b_device", 0644, usb3->dentry, usb3, + &renesas_usb3_b_device_fops); } /*------- platform_driver ------------------------------------------------*/
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi <balbi@kernel.org> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/usb/gadget/udc/renesas_usb3.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-)