| Message ID | 2a775652-604c-6379-b807-19979f164f84@cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 04, 2018 at 10:04:59PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU > hardware seems the same as in the R-Car V3M (R8A77970). > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > --- > The patch is against the 'drm-next' branch of David Airlie's 'linux.git' repo. > > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > 1 file changed, 2 insertions(+) > > Index: linux/Documentation/devicetree/bindings/display/renesas,du.txt > =================================================================== > --- linux.orig/Documentation/devicetree/bindings/display/renesas,du.txt > +++ linux/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -14,6 +14,7 @@ Required Properties: > - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU > - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU > - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU > + - "renesas,du-r8a77980" for R8A77980 (R-Car V3H) compatible DU > - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU > > - reg: the memory-mapped I/O registers base address and length > @@ -60,6 +61,7 @@ corresponding to each DU output. > R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0 > R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 - > R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - - > + R8A77980 (R-Car V3H) DPAD 0 LVDS 0 - - > R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 - > > >
Hi Sergei, Thank you for the patch. On Monday, 4 June 2018 22:04:59 EEST Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU > hardware seems the same as in the R-Car V3M (R8A77970). How about "the DU hardware has the same topology as in the R-Car V3M (R8A77970)" ? "seems" sounds like we're very unsure :-) > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > The patch is against the 'drm-next' branch of David Airlie's 'linux.git' > repo. Then you might want to switch to git://anongit.freedesktop.org/drm/drm :-) Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> If you agree with the small change to the commit message I'll fix the conflict locally, there's no need to resubmit. > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > 1 file changed, 2 insertions(+) > > Index: linux/Documentation/devicetree/bindings/display/renesas,du.txt > =================================================================== > --- linux.orig/Documentation/devicetree/bindings/display/renesas,du.txt > +++ linux/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -14,6 +14,7 @@ Required Properties: > - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU > - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU > - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU > + - "renesas,du-r8a77980" for R8A77980 (R-Car V3H) compatible DU > - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU > > - reg: the memory-mapped I/O registers base address and length > @@ -60,6 +61,7 @@ corresponding to each DU output. > R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0 > R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 - > R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - - > + R8A77980 (R-Car V3H) DPAD 0 LVDS 0 - - > R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
On 06/05/2018 01:09 PM, Laurent Pinchart wrote: >> Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU >> hardware seems the same as in the R-Car V3M (R8A77970). > > How about "the DU hardware has the same topology as in the R-Car V3M > (R8A77970)" ? "seems" sounds like we're very unsure :-) That's probably better, indeed. >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> --- >> The patch is against the 'drm-next' branch of David Airlie's 'linux.git' >> repo. > > Then you might want to switch to git://anongit.freedesktop.org/drm/drm :-) No, the corresponding MAINTAINERS records don't include drivers/gpu/drm/rcar-du/ or worse yet, the DU bindings. :-) Seriously, I thought you've done a patch to remove your dead 'fbdev' repo months ago and IO'm still seeing it listed... :-/ > Apart from that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > If you agree with the small change to the commit message I'll fix the conflict > locally, there's no need to resubmit. I do agree, except I don't know what conflict you mean. [...] MBR, Sergei
Hi Sergei, On Tuesday, 5 June 2018 21:57:47 EEST Sergei Shtylyov wrote: > On 06/05/2018 01:09 PM, Laurent Pinchart wrote: > >> Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU > >> hardware seems the same as in the R-Car V3M (R8A77970). > > > > How about "the DU hardware has the same topology as in the R-Car V3M > > (R8A77970)" ? "seems" sounds like we're very unsure :-) > > That's probably better, indeed. > > >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > >> --- > >> The patch is against the 'drm-next' branch of David Airlie's 'linux.git' > >> repo. > > > > Then you might want to switch to git://anongit.freedesktop.org/drm/drm :-) > > No, the corresponding MAINTAINERS records don't include > drivers/gpu/drm/rcar-du/ or worse yet, the DU bindings. :-) My point is that Dave's tree has moved. > Seriously, I thought you've done a patch to remove your dead 'fbdev' repo > months ago and IO'm still seeing it listed... :-/ I'll address that now. > > Apart from that, > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > If you agree with the small change to the commit message I'll fix the > > conflict locally, there's no need to resubmit. > > I do agree, except I don't know what conflict you mean. > > [...] I mean the conflict with commit dc8142901befabea974393d49b803f131243feb4 Author: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Date: Thu Apr 26 17:53:31 2018 +0100 dt-bindings: display: renesas: du: Document the r8a77965 bindings that is present in Dave's new tree.
On 06/05/2018 10:16 PM, Laurent Pinchart wrote: >>>> Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU >>>> hardware seems the same as in the R-Car V3M (R8A77970). >>> >>> How about "the DU hardware has the same topology as in the R-Car V3M >>> (R8A77970)" ? "seems" sounds like we're very unsure :-) >> >> That's probably better, indeed. >> >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> >>>> --- >>>> The patch is against the 'drm-next' branch of David Airlie's 'linux.git' >>>> repo. >>> >>> Then you might want to switch to git://anongit.freedesktop.org/drm/drm :-) >> >> No, the corresponding MAINTAINERS records don't include >> drivers/gpu/drm/rcar-du/ or worse yet, the DU bindings. :-) Well, there is still no corresponding record, actually... > My point is that Dave's tree has moved. How am I supposed to learn about it, from gossips? :-) >> Seriously, I thought you've done a patch to remove your dead 'fbdev' repo >> months ago and IO'm still seeing it listed... :-/ > > I'll address that now. TIA. >>> Apart from that, >>> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> >>> If you agree with the small change to the commit message I'll fix the >>> conflict locally, there's no need to resubmit. >> >> I do agree, except I don't know what conflict you mean. >> >> [...] > > I mean the conflict with > > commit dc8142901befabea974393d49b803f131243feb4 > Author: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Date: Thu Apr 26 17:53:31 2018 +0100 > > dt-bindings: display: renesas: du: Document the r8a77965 bindings > > that is present in Dave's new tree. Ah... TIA again. :-) MBR, Sergei
Hi Sergei, On Tuesday, 5 June 2018 22:49:57 EEST Sergei Shtylyov wrote: > On 06/05/2018 10:16 PM, Laurent Pinchart wrote: > >>>> Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU > >>>> hardware seems the same as in the R-Car V3M (R8A77970). > >>> > >>> How about "the DU hardware has the same topology as in the R-Car V3M > >>> (R8A77970)" ? "seems" sounds like we're very unsure :-) > >> > >> That's probably better, indeed. > >> > >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >>>> > >>>> --- > >>>> The patch is against the 'drm-next' branch of David Airlie's > >>>> 'linux.git' repo. > >>> > >>> Then you might want to switch to git://anongit.freedesktop.org/drm/drm > >>> :-) > >> > >> No, the corresponding MAINTAINERS records don't include > >> drivers/gpu/drm/rcar-du/ or worse yet, the DU bindings. :-) > > Well, there is still no corresponding record, actually... > > > My point is that Dave's tree has moved. > > How am I supposed to learn about it, from gossips? :-) I learnt it the hard way when a pull request I had prepared against the old tree conflicted (at compile time) with patches merged in the new tree. This broke the build, and I learnt about the new tree from a kbuild bot report. > >> Seriously, I thought you've done a patch to remove your dead 'fbdev' repo > >> months ago and IO'm still seeing it listed... :-/ > > > > I'll address that now. > > TIA. > > >>> Apart from that, > >>> > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> > >>> If you agree with the small change to the commit message I'll fix the > >>> conflict locally, there's no need to resubmit. > >> > >> I do agree, except I don't know what conflict you mean. > >> > >> [...] > > > > I mean the conflict with > > > > commit dc8142901befabea974393d49b803f131243feb4 > > Author: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Date: Thu Apr 26 17:53:31 2018 +0100 > > > > dt-bindings: display: renesas: du: Document the r8a77965 bindings > > > > that is present in Dave's new tree. > > Ah... TIA again. :-)
Hi Laurent, On Tue, Jun 5, 2018 at 10:24 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Tuesday, 5 June 2018 22:49:57 EEST Sergei Shtylyov wrote: >> On 06/05/2018 10:16 PM, Laurent Pinchart wrote: >> >>>> Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU >> >>>> hardware seems the same as in the R-Car V3M (R8A77970). >> >>> >> >>> How about "the DU hardware has the same topology as in the R-Car V3M >> >>> (R8A77970)" ? "seems" sounds like we're very unsure :-) >> >> >> >> That's probably better, indeed. >> >> >> >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >>>> >> >>>> --- >> >>>> The patch is against the 'drm-next' branch of David Airlie's >> >>>> 'linux.git' repo. >> >>> >> >>> Then you might want to switch to git://anongit.freedesktop.org/drm/drm >> >>> :-) >> >> >> >> No, the corresponding MAINTAINERS records don't include >> >> drivers/gpu/drm/rcar-du/ or worse yet, the DU bindings. :-) >> >> Well, there is still no corresponding record, actually... >> >> > My point is that Dave's tree has moved. >> >> How am I supposed to learn about it, from gossips? :-) > > I learnt it the hard way when a pull request I had prepared against the old > tree conflicted (at compile time) with patches merged in the new tree. This > broke the build, and I learnt about the new tree from a kbuild bot report. Updated repo list for renesas-drivers. Thanks for letting me know! Gr{oetje,eeting}s, Geert
On Mon, Jun 04, 2018 at 10:04:59PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU > hardware seems the same as in the R-Car V3M (R8A77970). > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > The patch is against the 'drm-next' branch of David Airlie's 'linux.git' repo. > > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
Index: linux/Documentation/devicetree/bindings/display/renesas,du.txt =================================================================== --- linux.orig/Documentation/devicetree/bindings/display/renesas,du.txt +++ linux/Documentation/devicetree/bindings/display/renesas,du.txt @@ -14,6 +14,7 @@ Required Properties: - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU + - "renesas,du-r8a77980" for R8A77980 (R-Car V3H) compatible DU - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU - reg: the memory-mapped I/O registers base address and length @@ -60,6 +61,7 @@ corresponding to each DU output. R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0 R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 - R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - - + R8A77980 (R-Car V3H) DPAD 0 LVDS 0 - - R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU hardware seems the same as in the R-Car V3M (R8A77970). Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against the 'drm-next' branch of David Airlie's 'linux.git' repo. Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ 1 file changed, 2 insertions(+)