| Message ID | 20180612003224.3658-2-labbott@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Laura,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Laura-Abbott/scripts-Preprocess-module-common-lds/20180612-083632
config: i386-randconfig-a1-201823 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
>> ld: cannot open linker script file scripts/module-common.lds: No such file or directory
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Laura,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Laura-Abbott/scripts-Preprocess-module-common-lds/20180612-083632
config: openrisc-or1ksim_defconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc
All errors (new ones prefixed by >>):
>> or1k-linux-ld: cannot open linker script file scripts/module-common.lds: No such file or directory
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
2018-06-12 9:32 GMT+09:00 Laura Abbott <labbott@redhat.com>: > > In preparation for some upcoming work, allow module-common.lds > to be run through the preprocessor. > > Signed-off-by: Laura Abbott <labbott@redhat.com> > --- > scripts/.gitignore | 1 + > scripts/Makefile | 2 +- > scripts/{module-common.lds => module-common.lds.S} | 0 > 3 files changed, 2 insertions(+), 1 deletion(-) > rename scripts/{module-common.lds => module-common.lds.S} (100%) > > diff --git a/scripts/.gitignore b/scripts/.gitignore > index 0442c06eefcb..afd1de57d9c6 100644 > --- a/scripts/.gitignore > +++ b/scripts/.gitignore > @@ -13,3 +13,4 @@ asn1_compiler > extract-cert > sign-file > insert-sys-cert > +module-common.lds > diff --git a/scripts/Makefile b/scripts/Makefile > index 25ab143cbe14..631d9d1a71e4 100644 > --- a/scripts/Makefile > +++ b/scripts/Makefile > @@ -25,7 +25,7 @@ HOSTCFLAGS_asn1_compiler.o = -I$(srctree)/include > HOSTLOADLIBES_sign-file = -lcrypto > HOSTLOADLIBES_extract-cert = -lcrypto > > -always := $(hostprogs-y) $(hostprogs-m) > +always := $(hostprogs-y) $(hostprogs-m) module-common.lds You do not need to generate module-common.lds all the time. It is necessary only when the module feature is enabled. You can do like this: extra-$(CONFIG_MODULES) += module-common.lds
diff --git a/scripts/.gitignore b/scripts/.gitignore index 0442c06eefcb..afd1de57d9c6 100644 --- a/scripts/.gitignore +++ b/scripts/.gitignore @@ -13,3 +13,4 @@ asn1_compiler extract-cert sign-file insert-sys-cert +module-common.lds diff --git a/scripts/Makefile b/scripts/Makefile index 25ab143cbe14..631d9d1a71e4 100644 --- a/scripts/Makefile +++ b/scripts/Makefile @@ -25,7 +25,7 @@ HOSTCFLAGS_asn1_compiler.o = -I$(srctree)/include HOSTLOADLIBES_sign-file = -lcrypto HOSTLOADLIBES_extract-cert = -lcrypto -always := $(hostprogs-y) $(hostprogs-m) +always := $(hostprogs-y) $(hostprogs-m) module-common.lds # The following hostprogs-y programs are only build on demand hostprogs-y += unifdef diff --git a/scripts/module-common.lds b/scripts/module-common.lds.S similarity index 100% rename from scripts/module-common.lds rename to scripts/module-common.lds.S
In preparation for some upcoming work, allow module-common.lds to be run through the preprocessor. Signed-off-by: Laura Abbott <labbott@redhat.com> --- scripts/.gitignore | 1 + scripts/Makefile | 2 +- scripts/{module-common.lds => module-common.lds.S} | 0 3 files changed, 2 insertions(+), 1 deletion(-) rename scripts/{module-common.lds => module-common.lds.S} (100%)