diff mbox

mfd: omap-usb-host: fix clock API usage on usbhs_disable()

Message ID 1311340170-28773-1-git-send-email-keshava_mgowda@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Munegowda, Keshava July 22, 2011, 1:09 p.m. UTC 
From: Keshava Munegowda <Keshava_mgowda@ti.com>

usbhs_disable function was invoking clk_enable() instead of
clk_disable(), thus only increasing the clock usage counter and
preventing this particular clock from being ever turned off.
Because of this, the power domain of omap4 the USB Host subsystem
would never reach lower power states.This patch calls clk_disable()
in usbhs_disable function

Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
---
 drivers/mfd/omap-usb-host.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Felipe Balbi July 26, 2011, 2:34 p.m. UTC | #1 
On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@ti.com>
> 
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
> 
> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>

Acked-by: Felipe Balbi <balbi@ti.com>

Samuel, I guess you can take this via MFD ?
Samuel Ortiz July 27, 2011, 9:53 a.m. UTC | #2 
Hi Keshava,

On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@ti.com>
> 
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
I applied this patch now, thanks.

Cheers,
Samuel.
Munegowda, Keshava July 27, 2011, 11:15 a.m. UTC | #3 
Thanks samuel


regards
keshava

On Wed, Jul 27, 2011 at 3:23 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Hi Keshava,
>
> On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
>> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>>
>> usbhs_disable function was invoking clk_enable() instead of
>> clk_disable(), thus only increasing the clock usage counter and
>> preventing this particular clock from being ever turned off.
>> Because of this, the power domain of omap4 the USB Host subsystem
>> would never reach lower power states.This patch calls clk_disable()
>> in usbhs_disable function
> I applied this patch now, thanks.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 1717144..29601e7 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -998,9 +998,9 @@  static void usbhs_disable(struct device *dev)
 
 	if (is_omap_usbhs_rev2(omap)) {
 		if (is_ehci_tll_mode(pdata->port_mode[0]))
-			clk_enable(omap->usbtll_p1_fck);
+			clk_disable(omap->usbtll_p1_fck);
 		if (is_ehci_tll_mode(pdata->port_mode[1]))
-			clk_enable(omap->usbtll_p2_fck);
+			clk_disable(omap->usbtll_p2_fck);
 		clk_disable(omap->utmi_p2_fck);
 		clk_disable(omap->utmi_p1_fck);
 	}