diff mbox

ath10k: Handle resource init failure case

Message ID 20180613064806.32286-1-govinds@codeaurora.org (mailing list archive)
State Accepted
Commit d16a7ab20ac9861979c83d7fce8f5edc48daada6
Delegated to: Kalle Valo
Headers show

Commit Message

Govind Singh June 13, 2018, 6:48 a.m. UTC
Return type of resource init method is not assigned.
Handle resource init failures for graceful exit.

Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/snoc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo June 14, 2018, 3:21 p.m. UTC | #1
Govind Singh <govinds@codeaurora.org> wrote:

> Return type of resource init method is not assigned.
> Handle resource init failures for graceful exit.
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

d16a7ab20ac9 ath10k: handle resource init failure case
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index aa8a9b36250e..a0504b8e003c 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -1500,13 +1500,13 @@  static int ath10k_snoc_probe(struct platform_device *pdev)
 	ar_snoc->ce.bus_ops = &ath10k_snoc_bus_ops;
 	ar->ce_priv = &ar_snoc->ce;
 
-	ath10k_snoc_resource_init(ar);
+	ret = ath10k_snoc_resource_init(ar);
 	if (ret) {
 		ath10k_warn(ar, "failed to initialize resource: %d\n", ret);
 		goto err_core_destroy;
 	}
 
-	ath10k_snoc_setup_resource(ar);
+	ret = ath10k_snoc_setup_resource(ar);
 	if (ret) {
 		ath10k_warn(ar, "failed to setup resource: %d\n", ret);
 		goto err_core_destroy;