| Message ID | 20180612054034.4969-2-songjun.wu@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, Jun 12, 2018 at 01:40:28PM +0800, Songjun Wu wrote: > Previous implementation uses a hard-coded register value to check if > the current serial entity is the console entity. > Now the lantiq serial driver uses the aliases for the index of the > serial port. > The lantiq danube serial dts are updated with aliases to support this. > > Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> > --- > > arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi > index 2dd950181f8a..7a9e15da6bd0 100644 > --- a/arch/mips/boot/dts/lantiq/danube.dtsi > +++ b/arch/mips/boot/dts/lantiq/danube.dtsi > @@ -4,6 +4,10 @@ > #size-cells = <1>; > compatible = "lantiq,xway", "lantiq,danube"; > > + aliases { > + serial0 = &asc1; > + }; > + > cpus { > cpu@0 { > compatible = "mips,mips24Kc"; > @@ -74,7 +78,7 @@ > reg = <0xE100A00 0x100>; > }; > > - serial@E100C00 { > + asc1: serial@E100C00 { Fix this to be lower case hex while you are at it. > compatible = "lantiq,asc"; > reg = <0xE100C00 0x400>; > interrupt-parent = <&icu0>; > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@linux.intel.com> wrote: > Previous implementation uses a hard-coded register value to check if > the current serial entity is the console entity. > Now the lantiq serial driver uses the aliases for the index of the > serial port. > The lantiq danube serial dts are updated with aliases to support this. > > Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> > --- > > arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi > index 2dd950181f8a..7a9e15da6bd0 100644 > --- a/arch/mips/boot/dts/lantiq/danube.dtsi > +++ b/arch/mips/boot/dts/lantiq/danube.dtsi > @@ -4,6 +4,10 @@ > #size-cells = <1>; > compatible = "lantiq,xway", "lantiq,danube"; > > + aliases { > + serial0 = &asc1; > + }; > + You generally want the aliases to be part of the board specific file, not every board numbers their serial ports in the same way. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/14/2018 6:03 PM, Arnd Bergmann wrote: > On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@linux.intel.com> wrote: >> Previous implementation uses a hard-coded register value to check if >> the current serial entity is the console entity. >> Now the lantiq serial driver uses the aliases for the index of the >> serial port. >> The lantiq danube serial dts are updated with aliases to support this. >> >> Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> >> --- >> >> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi >> index 2dd950181f8a..7a9e15da6bd0 100644 >> --- a/arch/mips/boot/dts/lantiq/danube.dtsi >> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi >> @@ -4,6 +4,10 @@ >> #size-cells = <1>; >> compatible = "lantiq,xway", "lantiq,danube"; >> >> + aliases { >> + serial0 = &asc1; >> + }; >> + > You generally want the aliases to be part of the board specific file, > not every board numbers their serial ports in the same way. > > Arnd In this chip only asc1 can be used as console, so serial0 is defined in chip specific file. -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 18, 2018 at 11:42 AM, Wu, Songjun <songjun.wu@linux.intel.com> wrote: > On 6/14/2018 6:03 PM, Arnd Bergmann wrote: >> >> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@linux.intel.com> >> wrote: >>> >>> Previous implementation uses a hard-coded register value to check if >>> the current serial entity is the console entity. >>> Now the lantiq serial driver uses the aliases for the index of the >>> serial port. >>> The lantiq danube serial dts are updated with aliases to support this. >>> >>> Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> >>> --- >>> >>> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi >>> b/arch/mips/boot/dts/lantiq/danube.dtsi >>> index 2dd950181f8a..7a9e15da6bd0 100644 >>> --- a/arch/mips/boot/dts/lantiq/danube.dtsi >>> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi >>> @@ -4,6 +4,10 @@ >>> #size-cells = <1>; >>> compatible = "lantiq,xway", "lantiq,danube"; >>> >>> + aliases { >>> + serial0 = &asc1; >>> + }; >>> + >> >> You generally want the aliases to be part of the board specific file, >> not every board numbers their serial ports in the same way. >> > > In this chip only asc1 can be used as console, so serial0 is defined in > chip specific file. This was a more general comment about 'aliases' being board specific in principle (though we've had exceptions in the past). Even if there is only one uart on the chip, I'd recommend following the same conventions as the other chips that have more than one uart. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/18/2018 6:59 PM, Arnd Bergmann wrote: > On Mon, Jun 18, 2018 at 11:42 AM, Wu, Songjun > <songjun.wu@linux.intel.com> wrote: >> On 6/14/2018 6:03 PM, Arnd Bergmann wrote: >>> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@linux.intel.com> >>> wrote: >>>> Previous implementation uses a hard-coded register value to check if >>>> the current serial entity is the console entity. >>>> Now the lantiq serial driver uses the aliases for the index of the >>>> serial port. >>>> The lantiq danube serial dts are updated with aliases to support this. >>>> >>>> Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> >>>> --- >>>> >>>> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi >>>> b/arch/mips/boot/dts/lantiq/danube.dtsi >>>> index 2dd950181f8a..7a9e15da6bd0 100644 >>>> --- a/arch/mips/boot/dts/lantiq/danube.dtsi >>>> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi >>>> @@ -4,6 +4,10 @@ >>>> #size-cells = <1>; >>>> compatible = "lantiq,xway", "lantiq,danube"; >>>> >>>> + aliases { >>>> + serial0 = &asc1; >>>> + }; >>>> + >>> You generally want the aliases to be part of the board specific file, >>> not every board numbers their serial ports in the same way. >>> >> In this chip only asc1 can be used as console, so serial0 is defined in >> chip specific file. > This was a more general comment about 'aliases' being board specific > in principle (though we've had exceptions in the past). Even if there > is only one uart on the chip, I'd recommend following the same > conventions as the other chips that have more than one uart. > > Arnd Accept, 'aliases' will be move to the board specific file. -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi index 2dd950181f8a..7a9e15da6bd0 100644 --- a/arch/mips/boot/dts/lantiq/danube.dtsi +++ b/arch/mips/boot/dts/lantiq/danube.dtsi @@ -4,6 +4,10 @@ #size-cells = <1>; compatible = "lantiq,xway", "lantiq,danube"; + aliases { + serial0 = &asc1; + }; + cpus { cpu@0 { compatible = "mips,mips24Kc"; @@ -74,7 +78,7 @@ reg = <0xE100A00 0x100>; }; - serial@E100C00 { + asc1: serial@E100C00 { compatible = "lantiq,asc"; reg = <0xE100C00 0x400>; interrupt-parent = <&icu0>;
Previous implementation uses a hard-coded register value to check if the current serial entity is the console entity. Now the lantiq serial driver uses the aliases for the index of the serial port. The lantiq danube serial dts are updated with aliases to support this. Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> --- arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)