diff mbox

[3/3] ARM: multi_v7_defconfig: enable STM32 SPI

Message ID 1526566904-24514-4-git-send-email-amelie.delaunay@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Amelie Delaunay May 17, 2018, 2:21 p.m. UTC
Enable the STM32 SPI driver, implemented on STM32MP1 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Alexandre TORGUE June 26, 2018, 8:44 a.m. UTC | #1
Hi Amélie

On 05/17/2018 04:21 PM, Amelie Delaunay wrote:
> Enable the STM32 SPI driver, implemented on STM32MP1 SoC.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 89167cd..f990335 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -411,6 +411,7 @@ CONFIG_SPI_S3C64XX=m
>   CONFIG_SPI_SH_MSIOF=m
>   CONFIG_SPI_SH_HSPI=y
>   CONFIG_SPI_SIRF=y
> +CONFIG_SPI_STM32=y
>   CONFIG_SPI_SUN4I=y
>   CONFIG_SPI_SUN6I=y
>   CONFIG_SPI_TEGRA114=y
> 

Driver which are are not "vital" to boot STM32 platform should be 
defined as module. It's the case for this one. Isn't ?

Regards
Alex
Amelie Delaunay June 26, 2018, 11:47 a.m. UTC | #2
Hi Alex

On 06/26/2018 10:44 AM, Alexandre Torgue wrote:
> Hi Amélie

> 

> On 05/17/2018 04:21 PM, Amelie Delaunay wrote:

>> Enable the STM32 SPI driver, implemented on STM32MP1 SoC.

>>

>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>

>> ---

>>   arch/arm/configs/multi_v7_defconfig | 1 +

>>   1 file changed, 1 insertion(+)

>>

>> diff --git a/arch/arm/configs/multi_v7_defconfig 

>> b/arch/arm/configs/multi_v7_defconfig

>> index 89167cd..f990335 100644

>> --- a/arch/arm/configs/multi_v7_defconfig

>> +++ b/arch/arm/configs/multi_v7_defconfig

>> @@ -411,6 +411,7 @@ CONFIG_SPI_S3C64XX=m

>>   CONFIG_SPI_SH_MSIOF=m

>>   CONFIG_SPI_SH_HSPI=y

>>   CONFIG_SPI_SIRF=y

>> +CONFIG_SPI_STM32=y

>>   CONFIG_SPI_SUN4I=y

>>   CONFIG_SPI_SUN6I=y

>>   CONFIG_SPI_TEGRA114=y

>>

> 

> Driver which are are not "vital" to boot STM32 platform should be 

> defined as module. It's the case for this one. Isn't ?

> 


You're right. I'll send v2 with CONFIG_SPI_STM32=m ASAP. Should I resend 
the whole patchset (with DT), or just this patch and you take the DT 
patches as they are ?

Regards,
Amelie
Alexandre TORGUE June 26, 2018, 12:13 p.m. UTC | #3
On 06/26/2018 01:47 PM, Amelie DELAUNAY wrote:
> Hi Alex
> 
> On 06/26/2018 10:44 AM, Alexandre Torgue wrote:
>> Hi Amélie
>> 
>> On 05/17/2018 04:21 PM, Amelie Delaunay wrote:
>>> Enable the STM32 SPI driver, implemented on STM32MP1 SoC.
>>>
>>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
>>> ---
>>>   arch/arm/configs/multi_v7_defconfig | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/configs/multi_v7_defconfig 
>>> b/arch/arm/configs/multi_v7_defconfig
>>> index 89167cd..f990335 100644
>>> --- a/arch/arm/configs/multi_v7_defconfig
>>> +++ b/arch/arm/configs/multi_v7_defconfig
>>> @@ -411,6 +411,7 @@ CONFIG_SPI_S3C64XX=m
>>>   CONFIG_SPI_SH_MSIOF=m
>>>   CONFIG_SPI_SH_HSPI=y
>>>   CONFIG_SPI_SIRF=y
>>> +CONFIG_SPI_STM32=y
>>>   CONFIG_SPI_SUN4I=y
>>>   CONFIG_SPI_SUN6I=y
>>>   CONFIG_SPI_TEGRA114=y
>>>
>> 
>> Driver which are are not "vital" to boot STM32 platform should be 
>> defined as module. It's the case for this one. Isn't ?
>> 
> 
> You're right. I'll send v2 with CONFIG_SPI_STM32=m ASAP. Should I resend
> the whole patchset (with DT), or just this patch and you take the DT
> patches as they are ?
> 

No, you can just resend this one. I will take DT part from this version.

Regards
Alex

> Regards,
> Amelie
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 89167cd..f990335 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -411,6 +411,7 @@  CONFIG_SPI_S3C64XX=m
 CONFIG_SPI_SH_MSIOF=m
 CONFIG_SPI_SH_HSPI=y
 CONFIG_SPI_SIRF=y
+CONFIG_SPI_STM32=y
 CONFIG_SPI_SUN4I=y
 CONFIG_SPI_SUN6I=y
 CONFIG_SPI_TEGRA114=y