| Message ID | 1529427424-12321-2-git-send-email-yibin.gong@nxp.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Jun 20, 2018 at 12:56:58AM +0800, Robin Gong wrote: > Correct to check the right rx dma cookie status in spit of it > works because only one cookie is running in the current sdma. > But it will not once sdma driver support multi cookies > running based on virt-dma. > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> Looks wrong (because of tx_status vs rx_cookie), but is right nevertheless I think: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe > --- > drivers/tty/serial/imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 4e85357..2879407 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -1051,7 +1051,7 @@ static void imx_uart_dma_rx_callback(void *data) > unsigned int r_bytes; > unsigned int bd_size; > > - status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state); > + status = dmaengine_tx_status(chan, sport->rx_cookie, &state); > > if (status == DMA_ERROR) { > imx_uart_clear_rx_errors(sport); > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On 26-06-18, 21:22, Uwe Kleine-König wrote: > On Wed, Jun 20, 2018 at 12:56:58AM +0800, Robin Gong wrote: > > Correct to check the right rx dma cookie status in spit of it > > works because only one cookie is running in the current sdma. > > But it will not once sdma driver support multi cookies > > running based on virt-dma. > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > Looks wrong (because of tx_status vs rx_cookie), but is right > nevertheless I think: hehe, tx refers to transfer status for rx (receive) cookie and not transmit .. yeah notations can be better! > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Thanks > Uwe > > > --- > > drivers/tty/serial/imx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > > index 4e85357..2879407 100644 > > --- a/drivers/tty/serial/imx.c > > +++ b/drivers/tty/serial/imx.c > > @@ -1051,7 +1051,7 @@ static void imx_uart_dma_rx_callback(void *data) > > unsigned int r_bytes; > > unsigned int bd_size; > > > > - status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state); > > + status = dmaengine_tx_status(chan, sport->rx_cookie, &state); > > > > if (status == DMA_ERROR) { > > imx_uart_clear_rx_errors(sport); > > -- > > 2.7.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ |
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 4e85357..2879407 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1051,7 +1051,7 @@ static void imx_uart_dma_rx_callback(void *data) unsigned int r_bytes; unsigned int bd_size; - status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state); + status = dmaengine_tx_status(chan, sport->rx_cookie, &state); if (status == DMA_ERROR) { imx_uart_clear_rx_errors(sport);
Correct to check the right rx dma cookie status in spit of it works because only one cookie is running in the current sdma. But it will not once sdma driver support multi cookies running based on virt-dma. Signed-off-by: Robin Gong <yibin.gong@nxp.com> --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)