| Message ID | 958e450a066289c94ba03429166c972c54be6fb3.1530402641.git.joeypabalinas@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas <joeypabalinas@gmail.com> wrote: > The firmware found in the touch screen of the Surface Pro 3 is slightly > buggy and occasionally doesn't send lift off reports for contacts; add > MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed > reports. > > Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> > > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 45968f7970f87775fa..a793076139d7d0db9b 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -242,11 +242,12 @@ static struct mt_class mt_classes[] = { > .quirks = MT_QUIRK_ALWAYS_VALID | > MT_QUIRK_IGNORE_DUPLICATES | > MT_QUIRK_HOVERING | > MT_QUIRK_CONTACT_CNT_ACCURATE | > MT_QUIRK_STICKY_FINGERS | > - MT_QUIRK_WIN8_PTP_BUTTONS }, > + MT_QUIRK_WIN8_PTP_BUTTONS | > + MT_QUIRK_NOT_SEEN_MEANS_UP }, NACK on this. If the Surface has a buggy firmware, we should handle it as a special case, not as a common failure. Also, I am not sure this quirk is compatible with Win 8 specification. Last, we now have a timeout for unreleased touches, so I really don't think you need that in recent kernels. Cheers, Benjamin > { .name = MT_CLS_EXPORT_ALL_INPUTS, > .quirks = MT_QUIRK_ALWAYS_VALID | > MT_QUIRK_CONTACT_CNT_ACCURATE, > .export_all_inputs = true }, > { .name = MT_CLS_WIN_8_DUAL, > -- > 2.18.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 03, 2018 at 09:53:19AM +0200, Benjamin Tissoires wrote: > NACK on this. > If the Surface has a buggy firmware, we should handle it as a special > case, not as a common failure. > Also, I am not sure this quirk is compatible with Win 8 specification. > Last, we now have a timeout for unreleased touches, so I really don't > think you need that in recent kernels. > > Cheers, > Benjamin > > > { .name = MT_CLS_EXPORT_ALL_INPUTS, > > .quirks = MT_QUIRK_ALWAYS_VALID | > > MT_QUIRK_CONTACT_CNT_ACCURATE, > > .export_all_inputs = true }, > > { .name = MT_CLS_WIN_8_DUAL, > > -- > > 2.18.0 > > Ah shoot, I had completely missed this reply to my earlier patchset, I apologize. Now that you mention it, I think handling it as a special case would be a better way to handle it, so I'll do a bit more research on the quirk thing and then revise my patches (assuming they end up as something still worth sending). Appreciate the comments, thanks.
On Thu, Aug 09, 2018 at 01:39:16PM -1000, Joey Pabalinas wrote: > The firmware found in the touch screen of the Surface Pro 3 is slightly > buggy and occasionally doesn't send lift off reports for contacts; add > MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed > reports. > > Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> Sorry, my mail filters are in need of some adjusting; I completely missed the review of the first send of this patchset :( Please disregard this resend, as I am going to revise it and submit a v2, thanks.
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 45968f7970f87775fa..a793076139d7d0db9b 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -242,11 +242,12 @@ static struct mt_class mt_classes[] = { .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_IGNORE_DUPLICATES | MT_QUIRK_HOVERING | MT_QUIRK_CONTACT_CNT_ACCURATE | MT_QUIRK_STICKY_FINGERS | - MT_QUIRK_WIN8_PTP_BUTTONS }, + MT_QUIRK_WIN8_PTP_BUTTONS | + MT_QUIRK_NOT_SEEN_MEANS_UP }, { .name = MT_CLS_EXPORT_ALL_INPUTS, .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_CONTACT_CNT_ACCURATE, .export_all_inputs = true }, { .name = MT_CLS_WIN_8_DUAL,
The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> 1 file changed, 2 insertions(+), 1 deletion(-)