| Message ID | 20180622045011.17452-1-woods.technical@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 21, 2018 at 11:50 PM Derald D. Woods <woods.technical@gmail.com> wrote: > > There are a few peripherals that generate some extra noise when they > don't have a regulator assigned to them. This patch assigns them to > the their actual tps65023 regulator 'vdd_io_reg' (VDCDC2). > Tony, Will you accept Derald's version of this patch? I know you wanted some changes my my version, but I think Derald's meets your requirements and it's much more accurate than what I was doing adam > Signed-off-by: Derald D. Woods <woods.technical@gmail.com> > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > arch/arm/boot/dts/am3517-evm.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/am3517-evm.dts b/arch/arm/boot/dts/am3517-evm.dts > index 98aadb0f81c5..19bc34348906 100644 > --- a/arch/arm/boot/dts/am3517-evm.dts > +++ b/arch/arm/boot/dts/am3517-evm.dts > @@ -127,6 +127,7 @@ > status = "okay"; > pinctrl-names = "default"; > enable-gpios = <&gpio6 16 GPIO_ACTIVE_HIGH>; /* gpio176, lcd INI */ > + vcc-supply = <&vdd_io_reg>; > > port { > lcd_in: endpoint { > @@ -154,6 +155,7 @@ > bl: backlight { > compatible = "pwm-backlight"; > pinctrl-names = "default"; > + power-supply = <&vdd_io_reg>; > pinctrl-0 = <&backlight_pins>; > pwms = <&pwm11 0 5000000 0>; > brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; > @@ -164,6 +166,7 @@ > pwm11: dmtimer-pwm@11 { > compatible = "ti,omap-dmtimer-pwm"; > pinctrl-names = "default"; > + pwm-supply = <&vdd_io_reg>; > pinctrl-0 = <&pwm_pins>; > ti,timers = <&timer11>; > #pwm-cells = <3>; > @@ -203,6 +206,7 @@ > reg = <0x21>; > gpio-controller; > #gpio-cells = <2>; > + vcc-supply = <&vdd_io_reg>; > }; > }; > > -- > 2.17.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [180703 12:12]: > On Thu, Jun 21, 2018 at 11:50 PM Derald D. Woods > <woods.technical@gmail.com> wrote: > > > > There are a few peripherals that generate some extra noise when they > > don't have a regulator assigned to them. This patch assigns them to > > the their actual tps65023 regulator 'vdd_io_reg' (VDCDC2). > > > > Tony, > > Will you accept Derald's version of this patch? I know you wanted > some changes my my version, but I think Derald's meets your > requirements and it's much more accurate than what I was doing Oh is that the patch "[PATCH v2] ARM: dts: am3517-evm: Add 'vdd_io_reg' regulator reference"? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 3, 2018 at 7:30 AM Tony Lindgren <tony@atomide.com> wrote: > > * Adam Ford <aford173@gmail.com> [180703 12:12]: > > On Thu, Jun 21, 2018 at 11:50 PM Derald D. Woods > > <woods.technical@gmail.com> wrote: > > > > > > There are a few peripherals that generate some extra noise when they > > > don't have a regulator assigned to them. This patch assigns them to > > > the their actual tps65023 regulator 'vdd_io_reg' (VDCDC2). > > > > > > > Tony, > > > > Will you accept Derald's version of this patch? I know you wanted > > some changes my my version, but I think Derald's meets your > > requirements and it's much more accurate than what I was doing > > Oh is that the patch "[PATCH v2] ARM: dts: am3517-evm: Add 'vdd_io_reg' > regulator reference"? > Yes please. It should accomplish what I wanted to do and do it better. :-) thank you adam > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 03, 2018 at 07:09:02AM -0500, Adam Ford wrote: > tatus: RO > Content-Length: 2293 > Lines: 65 > > On Thu, Jun 21, 2018 at 11:50 PM Derald D. Woods > <woods.technical@gmail.com> wrote: > > > > There are a few peripherals that generate some extra noise when they > > don't have a regulator assigned to them. This patch assigns them to > > the their actual tps65023 regulator 'vdd_io_reg' (VDCDC2). > > > > Tony, > > Will you accept Derald's version of this patch? I know you wanted > some changes my my version, but I think Derald's meets your > requirements and it's much more accurate than what I was doing I did the same for Texchnexion Twister to kill those warnings: pwm-backlight backlight: backlight supply power not found, using dummy regulator panel-dpi display: display supply vcc not found, using dummy regulator but as I have different hardware I cannot really add Tested-by. However, see bellow > > Signed-off-by: Derald D. Woods <woods.technical@gmail.com> > > Signed-off-by: Adam Ford <aford173@gmail.com> > > --- > > arch/arm/boot/dts/am3517-evm.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/boot/dts/am3517-evm.dts b/arch/arm/boot/dts/am3517-evm.dts > > index 98aadb0f81c5..19bc34348906 100644 > > --- a/arch/arm/boot/dts/am3517-evm.dts > > +++ b/arch/arm/boot/dts/am3517-evm.dts > > @@ -127,6 +127,7 @@ > > status = "okay"; > > pinctrl-names = "default"; > > enable-gpios = <&gpio6 16 GPIO_ACTIVE_HIGH>; /* gpio176, lcd INI */ > > + vcc-supply = <&vdd_io_reg>; > > > > port { > > lcd_in: endpoint { > > @@ -154,6 +155,7 @@ > > bl: backlight { > > compatible = "pwm-backlight"; > > pinctrl-names = "default"; > > + power-supply = <&vdd_io_reg>; > > pinctrl-0 = <&backlight_pins>; > > pwms = <&pwm11 0 5000000 0>; > > brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; > > @@ -164,6 +166,7 @@ > > pwm11: dmtimer-pwm@11 { > > compatible = "ti,omap-dmtimer-pwm"; > > pinctrl-names = "default"; > > + pwm-supply = <&vdd_io_reg>; Is the one above really needed? omap-dmtimer-pwm does not seem to ask for regulator. > > pinctrl-0 = <&pwm_pins>; > > ti,timers = <&timer11>; > > #pwm-cells = <3>; > > @@ -203,6 +206,7 @@ > > reg = <0x21>; > > gpio-controller; > > #gpio-cells = <2>; > > + vcc-supply = <&vdd_io_reg>; > > }; > > }; ladis -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 03, 2018 at 03:19:03PM +0200, Ladislav Michl wrote: > On Tue, Jul 03, 2018 at 07:09:02AM -0500, Adam Ford wrote: > > tatus: RO > > Content-Length: 2293 > > Lines: 65 > > > > On Thu, Jun 21, 2018 at 11:50 PM Derald D. Woods > > <woods.technical@gmail.com> wrote: > > > > > > There are a few peripherals that generate some extra noise when they > > > don't have a regulator assigned to them. This patch assigns them to > > > the their actual tps65023 regulator 'vdd_io_reg' (VDCDC2). > > > > > > > Tony, > > > > Will you accept Derald's version of this patch? I know you wanted > > some changes my my version, but I think Derald's meets your > > requirements and it's much more accurate than what I was doing > > I did the same for Texchnexion Twister to kill those warnings: > pwm-backlight backlight: backlight supply power not found, using dummy regulator > panel-dpi display: display supply vcc not found, using dummy regulator > but as I have different hardware I cannot really add Tested-by. However, > see bellow > > > > Signed-off-by: Derald D. Woods <woods.technical@gmail.com> > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > --- > > > arch/arm/boot/dts/am3517-evm.dts | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/am3517-evm.dts b/arch/arm/boot/dts/am3517-evm.dts > > > index 98aadb0f81c5..19bc34348906 100644 > > > --- a/arch/arm/boot/dts/am3517-evm.dts > > > +++ b/arch/arm/boot/dts/am3517-evm.dts > > > @@ -127,6 +127,7 @@ > > > status = "okay"; > > > pinctrl-names = "default"; > > > enable-gpios = <&gpio6 16 GPIO_ACTIVE_HIGH>; /* gpio176, lcd INI */ > > > + vcc-supply = <&vdd_io_reg>; > > > > > > port { > > > lcd_in: endpoint { > > > @@ -154,6 +155,7 @@ > > > bl: backlight { > > > compatible = "pwm-backlight"; > > > pinctrl-names = "default"; > > > + power-supply = <&vdd_io_reg>; > > > pinctrl-0 = <&backlight_pins>; > > > pwms = <&pwm11 0 5000000 0>; > > > brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; > > > @@ -164,6 +166,7 @@ > > > pwm11: dmtimer-pwm@11 { > > > compatible = "ti,omap-dmtimer-pwm"; > > > pinctrl-names = "default"; > > > + pwm-supply = <&vdd_io_reg>; > > Is the one above really needed? omap-dmtimer-pwm does not seem to ask for > regulator. > I will take a look tonight and report back on this thread. Derald > > > pinctrl-0 = <&pwm_pins>; > > > ti,timers = <&timer11>; > > > #pwm-cells = <3>; > > > @@ -203,6 +206,7 @@ > > > reg = <0x21>; > > > gpio-controller; > > > #gpio-cells = <2>; > > > + vcc-supply = <&vdd_io_reg>; > > > }; > > > }; > > ladis -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am3517-evm.dts b/arch/arm/boot/dts/am3517-evm.dts index 98aadb0f81c5..19bc34348906 100644 --- a/arch/arm/boot/dts/am3517-evm.dts +++ b/arch/arm/boot/dts/am3517-evm.dts @@ -127,6 +127,7 @@ status = "okay"; pinctrl-names = "default"; enable-gpios = <&gpio6 16 GPIO_ACTIVE_HIGH>; /* gpio176, lcd INI */ + vcc-supply = <&vdd_io_reg>; port { lcd_in: endpoint { @@ -154,6 +155,7 @@ bl: backlight { compatible = "pwm-backlight"; pinctrl-names = "default"; + power-supply = <&vdd_io_reg>; pinctrl-0 = <&backlight_pins>; pwms = <&pwm11 0 5000000 0>; brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; @@ -164,6 +166,7 @@ pwm11: dmtimer-pwm@11 { compatible = "ti,omap-dmtimer-pwm"; pinctrl-names = "default"; + pwm-supply = <&vdd_io_reg>; pinctrl-0 = <&pwm_pins>; ti,timers = <&timer11>; #pwm-cells = <3>; @@ -203,6 +206,7 @@ reg = <0x21>; gpio-controller; #gpio-cells = <2>; + vcc-supply = <&vdd_io_reg>; }; };