diff mbox

[RFC,2/5] dt-bindings: xilinx: Add missing zynq boards

Message ID 20180628054205.17737-3-luaraneda@gmail.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Luis Araneda June 28, 2018, 5:42 a.m. UTC
The bindings were missing when adding the device-tree files
Also, improve description of existing boards

Signed-off-by: Luis Araneda <luaraneda@gmail.com>
---
 .../devicetree/bindings/arm/xilinx.txt        | 22 +++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

Comments

Michal Simek June 28, 2018, 6:44 a.m. UTC | #1
On 28.6.2018 07:42, Luis Araneda wrote:
> The bindings were missing when adding the device-tree files
> Also, improve description of existing boards
> 
> Signed-off-by: Luis Araneda <luaraneda@gmail.com>
> ---
>  .../devicetree/bindings/arm/xilinx.txt        | 22 +++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
> index b9043bc35..f1e911058 100644
> --- a/Documentation/devicetree/bindings/arm/xilinx.txt
> +++ b/Documentation/devicetree/bindings/arm/xilinx.txt
> @@ -8,15 +8,33 @@ Required root node properties:
>  
>  Additional compatible strings:
>  
> -- Xilinx internal board cc108
> +- Xilinx CC108 board

No reason to remove internal word from here.

>    "xlnx,zynq-cc108"
>  
> -- Xilinx internal board zc770 with different FMC cards
> +- Avnet MicroZed board
> +  "avnet,zynq-microzed"
> +
> +- Adapteva Parallella board
> +  "adapteva,parallella"
> +
> +- Xilinx ZC702 board
> +  "xlnx,zynq-zc702"
> +
> +- Xilinx ZC706 board
> +  "xlnx,zynq-zc706"
> +
> +- Xilinx ZC770 board, with different FMC cards
>    "xlnx,zynq-zc770-xm010"
>    "xlnx,zynq-zc770-xm011"
>    "xlnx,zynq-zc770-xm012"
>    "xlnx,zynq-zc770-xm013"
>  
> +- Avnet ZedBoard board
> +  "avnet,zynq-zed"
> +
> +- Digilent Zybo board
> +  "digilent,zynq-zybo"
> +
>  - Digilent Zybo Z7 board
>    "digilent,zynq-zybo-z7"
>  
> 

Not a problem to add missing strings.

Thanks,
Michal
Luis Araneda July 3, 2018, 6:53 a.m. UTC | #2
Hi Michal,

On Thu, Jun 28, 2018 at 2:44 AM Michal Simek <michal.simek@xilinx.com> wrote:
> > -- Xilinx internal board cc108
> > +- Xilinx CC108 board
>
> No reason to remove internal word from here.

Ok.

Thanks,

Luis Araneda.
Rob Herring (Arm) July 3, 2018, 11:04 p.m. UTC | #3
On Thu, Jun 28, 2018 at 01:42:02AM -0400, Luis Araneda wrote:
> The bindings were missing when adding the device-tree files
> Also, improve description of existing boards
> 
> Signed-off-by: Luis Araneda <luaraneda@gmail.com>
> ---
>  .../devicetree/bindings/arm/xilinx.txt        | 22 +++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
> index b9043bc35..f1e911058 100644
> --- a/Documentation/devicetree/bindings/arm/xilinx.txt
> +++ b/Documentation/devicetree/bindings/arm/xilinx.txt
> @@ -8,15 +8,33 @@ Required root node properties:
>  
>  Additional compatible strings:
>  
> -- Xilinx internal board cc108
> +- Xilinx CC108 board
>    "xlnx,zynq-cc108"
>  
> -- Xilinx internal board zc770 with different FMC cards
> +- Avnet MicroZed board
> +  "avnet,zynq-microzed"
> +
> +- Adapteva Parallella board
> +  "adapteva,parallella"

This is documented in adapteva.txt, but I'd prefer if you put it 
here and remove adapteva.txt.

> +
> +- Xilinx ZC702 board
> +  "xlnx,zynq-zc702"
> +
> +- Xilinx ZC706 board
> +  "xlnx,zynq-zc706"
> +
> +- Xilinx ZC770 board, with different FMC cards
>    "xlnx,zynq-zc770-xm010"
>    "xlnx,zynq-zc770-xm011"
>    "xlnx,zynq-zc770-xm012"
>    "xlnx,zynq-zc770-xm013"
>  
> +- Avnet ZedBoard board
> +  "avnet,zynq-zed"
> +
> +- Digilent Zybo board
> +  "digilent,zynq-zybo"
> +
>  - Digilent Zybo Z7 board
>    "digilent,zynq-zybo-z7"
>  
> -- 
> 2.18.0
>
Luis Araneda July 5, 2018, 9:10 p.m. UTC | #4
Hi Rob,

Thanks for reviewing.

On Tue, Jul 3, 2018 at 7:04 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jun 28, 2018 at 01:42:02AM -0400, Luis Araneda wrote:
> > +- Adapteva Parallella board
> > +  "adapteva,parallella"
>
> This is documented in adapteva.txt, but I'd prefer if you put it
> here and remove adapteva.txt.

Ouch, I should have used git grep to find that.
I'll remove the adapteva.txt file on v2, which I'll be sending later today.

Thanks,

Luis Araneda.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
index b9043bc35..f1e911058 100644
--- a/Documentation/devicetree/bindings/arm/xilinx.txt
+++ b/Documentation/devicetree/bindings/arm/xilinx.txt
@@ -8,15 +8,33 @@  Required root node properties:
 
 Additional compatible strings:
 
-- Xilinx internal board cc108
+- Xilinx CC108 board
   "xlnx,zynq-cc108"
 
-- Xilinx internal board zc770 with different FMC cards
+- Avnet MicroZed board
+  "avnet,zynq-microzed"
+
+- Adapteva Parallella board
+  "adapteva,parallella"
+
+- Xilinx ZC702 board
+  "xlnx,zynq-zc702"
+
+- Xilinx ZC706 board
+  "xlnx,zynq-zc706"
+
+- Xilinx ZC770 board, with different FMC cards
   "xlnx,zynq-zc770-xm010"
   "xlnx,zynq-zc770-xm011"
   "xlnx,zynq-zc770-xm012"
   "xlnx,zynq-zc770-xm013"
 
+- Avnet ZedBoard board
+  "avnet,zynq-zed"
+
+- Digilent Zybo board
+  "digilent,zynq-zybo"
+
 - Digilent Zybo Z7 board
   "digilent,zynq-zybo-z7"