| Message ID | 20180709161129.28425-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
On Mon, Jul 9, 2018 at 6:11 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Avoids the inverted condition compared to the open coded version. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: linux-pm@vger.kernel.org > Cc: Eric Engestrom <eric.engestrom@intel.com> > -- > v2: Fix the logic fumble in the 2nd hunk, spotted by Eric. Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Or do you want me to apply it? > --- > include/linux/cpufreq.h | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index 882a9b9e34bc..3a774f523d00 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev, > > #define cpufreq_for_each_valid_entry(pos, table) \ > for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \ > - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \ > - continue; \ > - else > + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID) > > /* > * cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq > @@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev, > > #define cpufreq_for_each_valid_entry_idx(pos, table, idx) \ > cpufreq_for_each_entry_idx(pos, table, idx) \ > - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \ > - continue; \ > - else > + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID) > > > int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy, > -- > 2.18.0 >
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 882a9b9e34bc..3a774f523d00 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev, #define cpufreq_for_each_valid_entry(pos, table) \ for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \ - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \ - continue; \ - else + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID) /* * cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq @@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev, #define cpufreq_for_each_valid_entry_idx(pos, table, idx) \ cpufreq_for_each_entry_idx(pos, table, idx) \ - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \ - continue; \ - else + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID) int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
Avoids the inverted condition compared to the open coded version. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org Cc: Eric Engestrom <eric.engestrom@intel.com> -- v2: Fix the logic fumble in the 2nd hunk, spotted by Eric. --- include/linux/cpufreq.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)