| Message ID | 20180706090043.28363-1-govinds@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote: [snip] You still don't quite have the threading right on this series. All the other patches seem OK -- they have this in the header, which links them to the cover letter: In-Reply-To: <20180706085622.27945-1-govinds@codeaurora.org> References: <20180706085622.27945-1-govinds@codeaurora.org> But you seem to have missed that on this one patch for some reason. Brian
On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote: > Add device tree binding documentation details of msa > memory region for ath10k qmi client for SDM845/APQ8098 > SoC into "qcom,ath10k.txt". > > Signed-off-by: Govind Singh <govinds@codeaurora.org> > --- > .../bindings/net/wireless/qcom,ath10k.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 7fd4e8ce4149..87489054aea5 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -57,6 +57,16 @@ Optional properties: > - <supply-name>-supply: handle to the regulator device tree node > optional "supply-name" is "vdd-0.8-cx-mx". > > += SUBNODES: > +wcn3990-wifi node may contain one subnode, named "msa" representing > +the fixed msa memory regions used by the wifi firmware running in Q6. > +This sub-node must contain: Why do you need a sub-node? Just add memory-region property. > + > +- memory-region: > + Usage: required > + Value type: <phandle> > + Definition: reference to the reserved-memory for the region > + > Example (to supply the calibration data alone): > > In this example, the node is defined as child node of the PCI controller. > @@ -149,4 +159,7 @@ wifi@18000000 { > <0 140 0 /* CE10 */ >, > <0 141 0 /* CE11 */ >; > vdd-0.8-cx-mx-supply = <&pm8998_l5>; > + msa { > + memory-region = <&wifi_msa_mem>; > + }; > }; > -- > 2.17.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On 2018-07-11 20:57, Rob Herring wrote: > On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote: >> Add device tree binding documentation details of msa >> memory region for ath10k qmi client for SDM845/APQ8098 >> SoC into "qcom,ath10k.txt". >> >> Signed-off-by: Govind Singh <govinds@codeaurora.org> >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 13 >> +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 7fd4e8ce4149..87489054aea5 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -57,6 +57,16 @@ Optional properties: >> - <supply-name>-supply: handle to the regulator device tree node >> optional "supply-name" is "vdd-0.8-cx-mx". >> >> += SUBNODES: >> +wcn3990-wifi node may contain one subnode, named "msa" representing >> +the fixed msa memory regions used by the wifi firmware running in Q6. >> +This sub-node must contain: > > Why do you need a sub-node? Just add memory-region property. > Fixed in v4 version. Thanks, Govind
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 7fd4e8ce4149..87489054aea5 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -57,6 +57,16 @@ Optional properties: - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" is "vdd-0.8-cx-mx". += SUBNODES: +wcn3990-wifi node may contain one subnode, named "msa" representing +the fixed msa memory regions used by the wifi firmware running in Q6. +This sub-node must contain: + +- memory-region: + Usage: required + Value type: <phandle> + Definition: reference to the reserved-memory for the region + Example (to supply the calibration data alone): In this example, the node is defined as child node of the PCI controller. @@ -149,4 +159,7 @@ wifi@18000000 { <0 140 0 /* CE10 */ >, <0 141 0 /* CE11 */ >; vdd-0.8-cx-mx-supply = <&pm8998_l5>; + msa { + memory-region = <&wifi_msa_mem>; + }; };
Add device tree binding documentation details of msa memory region for ath10k qmi client for SDM845/APQ8098 SoC into "qcom,ath10k.txt". Signed-off-by: Govind Singh <govinds@codeaurora.org> --- .../bindings/net/wireless/qcom,ath10k.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+)