| Message ID | 1531134767-29927-2-git-send-email-jian.hu@amlogic.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
adding Rob Herring so it doesn't get lost on the devicetree mailing list On Mon, Jul 9, 2018 at 1:13 PM Jian Hu <jian.hu@amlogic.com> wrote: > > Add new binding for Meson-G12A SoC Everything-Else part > > Signed-off-by: Jian Hu <jian.hu@amlogic.com> > --- > Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt > index e950599..0833006 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt > @@ -9,6 +9,7 @@ Required Properties: > "amlogic,gxbb-clkc" for GXBB SoC, > "amlogic,gxl-clkc" for GXL and GXM SoC, > "amlogic,axg-clkc" for AXG SoC. > + "amlogic,g12a-clkc" for G12A SoC. should this be "amlogic,meson-g12a-clkc" instead? that would make it consistent with virtually all other bindings which use the schema "amlogic,meson<chip>-<ip-block>" (where chip is 8, 8b, 8m2, -gxbb, -gxl, ...) see also: $ grep -R "amlogic," Documentation/devicetree/bindings/ > > - #clock-cells: should be 1. > > -- > 1.9.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic
On Mon, 2018-07-09 at 19:12 +0800, Jian Hu wrote: > Add new binding for Meson-G12A SoC Everything-Else part nitpick: I would prefer if the words 'clock' and 'controller' was somewhere in the description. Maybe "add new clock controller compatible for the EE domain of the g12a SoC" ? > > Signed-off-by: Jian Hu <jian.hu@amlogic.com> > --- > Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt > index e950599..0833006 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt > @@ -9,6 +9,7 @@ Required Properties: > "amlogic,gxbb-clkc" for GXBB SoC, > "amlogic,gxl-clkc" for GXL and GXM SoC, > "amlogic,axg-clkc" for AXG SoC. > + "amlogic,g12a-clkc" for G12A SoC. > > - #clock-cells: should be 1. >
On 2018/7/10 5:57, Martin Blumenstingl wrote: > adding Rob Herring so it doesn't get lost on the devicetree mailing list > > On Mon, Jul 9, 2018 at 1:13 PM Jian Hu <jian.hu@amlogic.com> wrote: >> >> Add new binding for Meson-G12A SoC Everything-Else part >> >> Signed-off-by: Jian Hu <jian.hu@amlogic.com> >> --- >> Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt >> index e950599..0833006 100644 >> --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt >> +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt >> @@ -9,6 +9,7 @@ Required Properties: >> "amlogic,gxbb-clkc" for GXBB SoC, >> "amlogic,gxl-clkc" for GXL and GXM SoC, >> "amlogic,axg-clkc" for AXG SoC. >> + "amlogic,g12a-clkc" for G12A SoC. > should this be "amlogic,meson-g12a-clkc" instead? > that would make it consistent with virtually all other bindings which > use the schema "amlogic,meson<chip>-<ip-block>" (where chip is 8, 8b, > 8m2, -gxbb, -gxl, ...) > > see also: $ grep -R "amlogic," Documentation/devicetree/bindings/ > Which type should we choose,have a discussion? .compatible = "amlogic,g12a-clkc or .compatible = "amlogic,meson-g12a-clkc >> >> - #clock-cells: should be 1. >> >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic > > . >
On 2018/7/10 17:29, Jerome Brunet wrote: > On Mon, 2018-07-09 at 19:12 +0800, Jian Hu wrote: >> Add new binding for Meson-G12A SoC Everything-Else part > > nitpick: I would prefer if the words 'clock' and 'controller' was somewhere in > the description. > > Maybe "add new clock controller compatible for the EE domain of the g12a SoC" ? Patch 1 and 2 have squashed, the commit message focuse which one？ > >> >> Signed-off-by: Jian Hu <jian.hu@amlogic.com> >> --- >> Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt >> index e950599..0833006 100644 >> --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt >> +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt >> @@ -9,6 +9,7 @@ Required Properties: >> "amlogic,gxbb-clkc" for GXBB SoC, >> "amlogic,gxl-clkc" for GXL and GXM SoC, >> "amlogic,axg-clkc" for AXG SoC. >> + "amlogic,g12a-clkc" for G12A SoC. >> >> - #clock-cells: should be 1. >> > > . >
On Wed, Jul 11, 2018 at 3:06 PM Jian Hu <jian.hu@amlogic.com> wrote: > > > > On 2018/7/10 17:29, Jerome Brunet wrote: > > On Mon, 2018-07-09 at 19:12 +0800, Jian Hu wrote: > >> Add new binding for Meson-G12A SoC Everything-Else part > > > > nitpick: I would prefer if the words 'clock' and 'controller' was somewhere in > > the description. > > > > Maybe "add new clock controller compatible for the EE domain of the g12a SoC" ? > > Patch 1 and 2 have squashed, the commit message focuse which one？ I would use the information from both commit messages (for example you could use the what Jerome already suggested and extend it with "and add a header file which contains preprocessor macros to identify the clocks provided by this clock controller") Regards Martin
diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt index e950599..0833006 100644 --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt @@ -9,6 +9,7 @@ Required Properties: "amlogic,gxbb-clkc" for GXBB SoC, "amlogic,gxl-clkc" for GXL and GXM SoC, "amlogic,axg-clkc" for AXG SoC. + "amlogic,g12a-clkc" for G12A SoC. - #clock-cells: should be 1.
Add new binding for Meson-G12A SoC Everything-Else part Signed-off-by: Jian Hu <jian.hu@amlogic.com> --- Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 + 1 file changed, 1 insertion(+)