| Message ID | 1531773542-15736-2-git-send-email-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, * Neil Armstrong <narmstrong@baylibre.com> [180716 20:42]: > Add the missing fck clock to all timer nodes of the AM33XX dtsi. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 9cd62bc2..e8e665d 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -541,6 +541,8 @@ > reg = <0x48042000 0x400>; > interrupts = <69>; > ti,hwmods = "timer3"; > + clocks = <&timer3_fck>; > + clock-names = "fck"; > }; These should all use the clkctrl clock nodes, see: $ git grep CLKCTRL include/dt-bindings/clock/ | grep TIMER The module clock is bit 0, and on some SoCs bit 24 is the timer fck. But I don't think these SoS use separate bit 24 clock. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tony, On 17/07/2018 07:55, Tony Lindgren wrote: > Hi, > > * Neil Armstrong <narmstrong@baylibre.com> [180716 20:42]: >> Add the missing fck clock to all timer nodes of the AM33XX dtsi. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> arch/arm/boot/dts/am33xx.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index 9cd62bc2..e8e665d 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -541,6 +541,8 @@ >> reg = <0x48042000 0x400>; >> interrupts = <69>; >> ti,hwmods = "timer3"; >> + clocks = <&timer3_fck>; >> + clock-names = "fck"; >> }; > > These should all use the clkctrl clock nodes, see: Even the already configured timer1 & timer2 ? > > $ git grep CLKCTRL include/dt-bindings/clock/ | grep TIMER > > The module clock is bit 0, and on some SoCs bit 24 is the > timer fck. But I don't think these SoS use separate bit 24 > clock. > > Regards, > > Tony > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Neil Armstrong <narmstrong@baylibre.com> [180717 20:31]: > On 17/07/2018 07:55, Tony Lindgren wrote: > > These should all use the clkctrl clock nodes, see: > > Even the already configured timer1 & timer2 ? Yeah that way things will work in a generic way for the SoCs using clkctrl registers. That's omap4 and later and including ti81xx. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 9cd62bc2..e8e665d 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -541,6 +541,8 @@ reg = <0x48042000 0x400>; interrupts = <69>; ti,hwmods = "timer3"; + clocks = <&timer3_fck>; + clock-names = "fck"; }; timer4: timer@48044000 { @@ -548,6 +550,8 @@ reg = <0x48044000 0x400>; interrupts = <92>; ti,hwmods = "timer4"; + clocks = <&timer4_fck>; + clock-names = "fck"; ti,timer-pwm; }; @@ -556,6 +560,8 @@ reg = <0x48046000 0x400>; interrupts = <93>; ti,hwmods = "timer5"; + clocks = <&timer5_fck>; + clock-names = "fck"; ti,timer-pwm; }; @@ -564,6 +570,8 @@ reg = <0x48048000 0x400>; interrupts = <94>; ti,hwmods = "timer6"; + clocks = <&timer6_fck>; + clock-names = "fck"; ti,timer-pwm; }; @@ -572,6 +580,8 @@ reg = <0x4804a000 0x400>; interrupts = <95>; ti,hwmods = "timer7"; + clocks = <&timer7_fck>; + clock-names = "fck"; ti,timer-pwm; };
Add the missing fck clock to all timer nodes of the AM33XX dtsi. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm/boot/dts/am33xx.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)