Message ID | 20180718161035.7005-4-brgl@bgdev.pl (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Jul 18, 2018 at 06:10:33PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > We'll soon have more sources from which to read the MAC address in this > routine. Make sure the address is correct before returning it. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c index 2a2173324d9e..6b64586fd2af 100644 --- a/net/ethernet/eth.c +++ b/net/ethernet/eth.c @@ -544,7 +544,7 @@ int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr) from = "arch callback"; } - if (!addr) + if (!addr || !is_valid_ether_addr(addr)) return -ENODEV; dev_info(dev, "read MAC address from %s\n", from);