| Message ID | 20180718215716.5784-1-lyude@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote: > This isn't supposed to take dev as an argument, I guess no one noticed! Apparently no one using it... Why don't we just kill it? > > Signed-off-by: Lyude Paul <lyude@redhat.com> anyways, if you prefer to keep or have plans to use: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > include/drm/drm_print.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index 767c90b654c5..fc08584a5101 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -310,7 +310,7 @@ void drm_err(const char *format, ...); > > #define DRM_DEV_DEBUG_DP(dev, fmt, ...) \ > drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) > -#define DRM_DEBUG_DP(dev, fmt, ...) \ > +#define DRM_DEBUG_DP(fmt, ...) \ > drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__) > > #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \ > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, 2018-07-18 at 16:07 -0700, Rodrigo Vivi wrote: > On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote: > > This isn't supposed to take dev as an argument, I guess no one noticed! > > Apparently no one using it... Why don't we just kill it? Yeah-I've got plans to hopefully use this at some point in the future > > > > > Signed-off-by: Lyude Paul <lyude@redhat.com> > > anyways, if you prefer to keep or have plans to use: > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > --- > > include/drm/drm_print.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > > index 767c90b654c5..fc08584a5101 100644 > > --- a/include/drm/drm_print.h > > +++ b/include/drm/drm_print.h > > @@ -310,7 +310,7 @@ void drm_err(const char *format, ...); > > > > #define DRM_DEV_DEBUG_DP(dev, fmt, ...) > > \ > > drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) > > -#define DRM_DEBUG_DP(dev, fmt, ...) > > \ > > +#define DRM_DEBUG_DP(fmt, ...) > > \ > > drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__) > > > > #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) > > \ > > -- > > 2.17.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 767c90b654c5..fc08584a5101 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -310,7 +310,7 @@ void drm_err(const char *format, ...); #define DRM_DEV_DEBUG_DP(dev, fmt, ...) \ drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) -#define DRM_DEBUG_DP(dev, fmt, ...) \ +#define DRM_DEBUG_DP(fmt, ...) \ drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__) #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \
This isn't supposed to take dev as an argument, I guess no one noticed! Signed-off-by: Lyude Paul <lyude@redhat.com> --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)