mbox series

[v2,0/5] HID: hid-betopff.c: Minor code refactoring

Message ID 84e73143-a5da-9e8d-4ec8-ce425e1b4699@hanno.de (mailing list archive)
Headers show
Series HID: hid-betopff.c: Minor code refactoring | expand

Message

Hanno Zulla July 23, 2018, 3:02 p.m. UTC 
Hello Huang,
hello Benjamin,

the code of hid-betopff.c served as my guide when writing a
driver for a different gamepad device. Thanks!

Benjamin commented a few issues in my new driver that also
applied to your driver, so allow me to fix those here, too.

This is v2 of my previous patch. It contains a minor reshuffling
of the code so that _init() can be folded back into _probe(),
which will fix the error handling. Afterwards, devm_kzalloc()
is used to make kfree() obsolete.

Benjamin, I do not own the gamepad for this driver. My patched
version compiles cleanly, but please have a look over it.

Thank you,

Hanno
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Benjamin Tissoires July 24, 2018, 9:01 a.m. UTC | #1 
On Mon, Jul 23, 2018 at 5:02 PM Hanno Zulla <abos@hanno.de> wrote:
>
> Hello Huang,
> hello Benjamin,
>
> the code of hid-betopff.c served as my guide when writing a
> driver for a different gamepad device. Thanks!
>
> Benjamin commented a few issues in my new driver that also
> applied to your driver, so allow me to fix those here, too.
>
> This is v2 of my previous patch. It contains a minor reshuffling
> of the code so that _init() can be folded back into _probe(),
> which will fix the error handling. Afterwards, devm_kzalloc()
> is used to make kfree() obsolete.
>
> Benjamin, I do not own the gamepad for this driver. My patched
> version compiles cleanly, but please have a look over it.

Series looks good:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Jiri, please merge this only with Huang's tested by please.

Cheers,
Benjamin

>
> Thank you,
>
> Hanno
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hanno Zulla July 24, 2018, 9:13 a.m. UTC | #2 
Hi,

> Series looks good:

Thanks.

> Jiri, please merge this only with Huang's tested by please.

Ok. Huang, are you there and could you please test this with
your device? You haven't responded to my last patch and your
last appearance on this list was four years ago.

Kind regards,

Hanno
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hanno Zulla Sept. 19, 2018, 9:18 a.m. UTC | #3 
Hello,

> Series looks good:> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>> > Jiri, please merge this only with Huang's tested by please.
There has been no response from Huang to a testing request
since more than two months.

My patch is just a minor refactoring. I'm aware that I cannot test
the device myself, but I had refactored the same code parts for
the Sony hid driver and for my bigbenff-driver with no issue.

Kind regards,

Hanno