| Message ID | 1531060324-116592-8-git-send-email-vadimp@mellanox.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Sun, Jul 08, 2018 at 02:32:03PM +0000, Vadim Pasternak wrote: > Change mlxreg-io platform driver configuration for MSN274x system types > from the default to MSN21xx. > > Fixes: 8871f5e42341 ("mlx-platform: Add mlxreg-io platform driver activation") Is this a fix, or is this enabling the development now possible with this series for the MSN274x systems? A Fixes implies there was an error in the referenced commit (it should have been done differently at the time). > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > --- > drivers/platform/x86/mlx-platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c > index 4276fb2..c725c2d 100644 > --- a/drivers/platform/x86/mlx-platform.c > +++ b/drivers/platform/x86/mlx-platform.c > @@ -1008,7 +1008,7 @@ static struct mlxreg_core_platform_data mlxplat_default_regs_io_data = { > .counter = ARRAY_SIZE(mlxplat_mlxcpld_default_regs_io_data), > }; > > -/* Platform register access MSN21xx, MSN201x systems families data */ > +/* Platform register access MSN21xx, MSN201x, MSN274x systems families data */ > static struct mlxreg_core_data mlxplat_mlxcpld_msn21xx_regs_io_data[] = { > { > .label = "cpld1_version", > @@ -1405,7 +1405,7 @@ static int __init mlxplat_dmi_msn274x_matched(const struct dmi_system_id *dmi) > mlxplat_hotplug->deferred_nr = > mlxplat_msn21xx_channels[MLXPLAT_CPLD_GRP_CHNL_NUM - 1]; > mlxplat_led = &mlxplat_default_led_data; > - mlxplat_regs_io = &mlxplat_default_regs_io_data; > + mlxplat_regs_io = &mlxplat_msn21xx_regs_io_data; > > return 1; > }; > -- > 2.1.4 > >
> -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Thursday, July 26, 2018 1:11 AM > To: Vadim Pasternak <vadimp@mellanox.com> > Cc: andy.shevchenko@gmail.com; gregkh@linuxfoundation.org; platform- > driver-x86@vger.kernel.org; jiri@resnulli.us; Michael Shych > <michaelsh@mellanox.com>; ivecera@redhat.com > Subject: Re: [PATCH v1 7/8] platform/x86: mlx-platform: Change mlxreg-io > configuration for MSN274x systems > > On Sun, Jul 08, 2018 at 02:32:03PM +0000, Vadim Pasternak wrote: > > Change mlxreg-io platform driver configuration for MSN274x system > > types from the default to MSN21xx. > > > > Fixes: 8871f5e42341 ("mlx-platform: Add mlxreg-io platform driver > > activation") > > Is this a fix, or is this enabling the development now possible with this series for > the MSN274x systems? A Fixes implies there was an error in the referenced > commit (it should have been done differently at the time). I used default data for register access. Now I changed to more relevant data, which is new. So, it's really not a bag, yes you are right. > > > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > > --- > > drivers/platform/x86/mlx-platform.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/platform/x86/mlx-platform.c > > b/drivers/platform/x86/mlx-platform.c > > index 4276fb2..c725c2d 100644 > > --- a/drivers/platform/x86/mlx-platform.c > > +++ b/drivers/platform/x86/mlx-platform.c > > @@ -1008,7 +1008,7 @@ static struct mlxreg_core_platform_data > mlxplat_default_regs_io_data = { > > .counter = ARRAY_SIZE(mlxplat_mlxcpld_default_regs_io_data), > > }; > > > > -/* Platform register access MSN21xx, MSN201x systems families data */ > > +/* Platform register access MSN21xx, MSN201x, MSN274x systems > > +families data */ > > static struct mlxreg_core_data mlxplat_mlxcpld_msn21xx_regs_io_data[] = { > > { > > .label = "cpld1_version", > > @@ -1405,7 +1405,7 @@ static int __init > mlxplat_dmi_msn274x_matched(const struct dmi_system_id *dmi) > > mlxplat_hotplug->deferred_nr = > > mlxplat_msn21xx_channels[MLXPLAT_CPLD_GRP_CHNL_NUM - > 1]; > > mlxplat_led = &mlxplat_default_led_data; > > - mlxplat_regs_io = &mlxplat_default_regs_io_data; > > + mlxplat_regs_io = &mlxplat_msn21xx_regs_io_data; > > > > return 1; > > }; > > -- > > 2.1.4 > > > > > > -- > Darren Hart > VMware Open Source Technology Center
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c index 4276fb2..c725c2d 100644 --- a/drivers/platform/x86/mlx-platform.c +++ b/drivers/platform/x86/mlx-platform.c @@ -1008,7 +1008,7 @@ static struct mlxreg_core_platform_data mlxplat_default_regs_io_data = { .counter = ARRAY_SIZE(mlxplat_mlxcpld_default_regs_io_data), }; -/* Platform register access MSN21xx, MSN201x systems families data */ +/* Platform register access MSN21xx, MSN201x, MSN274x systems families data */ static struct mlxreg_core_data mlxplat_mlxcpld_msn21xx_regs_io_data[] = { { .label = "cpld1_version", @@ -1405,7 +1405,7 @@ static int __init mlxplat_dmi_msn274x_matched(const struct dmi_system_id *dmi) mlxplat_hotplug->deferred_nr = mlxplat_msn21xx_channels[MLXPLAT_CPLD_GRP_CHNL_NUM - 1]; mlxplat_led = &mlxplat_default_led_data; - mlxplat_regs_io = &mlxplat_default_regs_io_data; + mlxplat_regs_io = &mlxplat_msn21xx_regs_io_data; return 1; };
Change mlxreg-io platform driver configuration for MSN274x system types from the default to MSN21xx. Fixes: 8871f5e42341 ("mlx-platform: Add mlxreg-io platform driver activation") Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> --- drivers/platform/x86/mlx-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)