| Message ID | 20180726092220.17250-7-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | provide power off support for iMX6 with external PMIC | expand |
> -----Original Message----- > From: Oleksij Rempel [mailto:o.rempel@pengutronix.de] > Sent: 2018年7月26日 17:22 > To: Shawn Guo <shawnguo@kernel.org>; Mark Brown <broonie@kernel.org>; > Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>; kernel@pengutronix.de; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > <akpm@linux-foundation.org>; Liam Girdwood <lgirdwood@gmail.com>; > Leonard Crestez <leonard.crestez@nxp.com>; Rob Herring > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Michael > Turquette <mturquette@baylibre.com>; Stephen Boyd > <sboyd@codeaurora.org>; Fabio Estevam <fabio.estevam@nxp.com>; Russell > King <linux@armlinux.org.uk>; dl-linux-imx <linux-imx@nxp.com>; Robin Gong > <yibin.gong@nxp.com>; A.s. Dong <aisheng.dong@nxp.com> > Subject: [PATCH v8 6/6] ARM: dts: imx6: RIoTboard provide standby on power > off option > > This board, as well as some other boards with i.MX6 and a PMIC, uses a > "PMIC_STBY_REQ" line to notify the PMIC about a state change. > The PMIC is programmed for a specific state change before triggering the line. > In this case, PMIC_STBY_REQ can be used for stand by, sleep and power off > modes. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > arch/arm/boot/dts/imx6dl-riotboard.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts > b/arch/arm/boot/dts/imx6dl-riotboard.dts > index 2e98c92adff7..a0e9753ee767 100644 > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts > @@ -90,6 +90,10 @@ > status = "okay"; > }; > > +&clks { > + fsl,pmic-stby-poweroff; > +}; It's better remove the default "syscon-poweroff" power off node. > + > &fec { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet>; > @@ -170,6 +174,7 @@ > reg = <0x08>; > interrupt-parent = <&gpio5>; > interrupts = <16 8>; > + fsl,pmic-stby-poweroff; > > regulators { > reg_vddcore: sw1ab { /* VDDARM_IN */ > -- > 2.18.0
On 27.07.2018 11:33, Robin Gong wrote: > > >> -----Original Message----- >> From: Oleksij Rempel [mailto:o.rempel@pengutronix.de] >> Sent: 2018年7月26日 17:22 >> To: Shawn Guo <shawnguo@kernel.org>; Mark Brown <broonie@kernel.org>; >> Rafael J. Wysocki <rafael.j.wysocki@intel.com> >> Cc: Oleksij Rempel <o.rempel@pengutronix.de>; kernel@pengutronix.de; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton >> <akpm@linux-foundation.org>; Liam Girdwood <lgirdwood@gmail.com>; >> Leonard Crestez <leonard.crestez@nxp.com>; Rob Herring >> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Michael >> Turquette <mturquette@baylibre.com>; Stephen Boyd >> <sboyd@codeaurora.org>; Fabio Estevam <fabio.estevam@nxp.com>; Russell >> King <linux@armlinux.org.uk>; dl-linux-imx <linux-imx@nxp.com>; Robin Gong >> <yibin.gong@nxp.com>; A.s. Dong <aisheng.dong@nxp.com> >> Subject: [PATCH v8 6/6] ARM: dts: imx6: RIoTboard provide standby on power >> off option >> >> This board, as well as some other boards with i.MX6 and a PMIC, uses a >> "PMIC_STBY_REQ" line to notify the PMIC about a state change. >> The PMIC is programmed for a specific state change before triggering the line. >> In this case, PMIC_STBY_REQ can be used for stand by, sleep and power off >> modes. >> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >> --- >> arch/arm/boot/dts/imx6dl-riotboard.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts >> b/arch/arm/boot/dts/imx6dl-riotboard.dts >> index 2e98c92adff7..a0e9753ee767 100644 >> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts >> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts >> @@ -90,6 +90,10 @@ >> status = "okay"; >> }; >> >> +&clks { >> + fsl,pmic-stby-poweroff; >> +}; > It's better remove the default "syscon-poweroff" power off node. ok >> &fec { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_enet>; >> @@ -170,6 +174,7 @@ >> reg = <0x08>; >> interrupt-parent = <&gpio5>; >> interrupts = <16 8>; >> + fsl,pmic-stby-poweroff; >> >> regulators { >> reg_vddcore: sw1ab { /* VDDARM_IN */ >> -- >> 2.18.0 >
On 27.07.2018 11:33, Robin Gong wrote: > > >> -----Original Message----- >> From: Oleksij Rempel [mailto:o.rempel@pengutronix.de] >> Sent: 2018年7月26日 17:22 >> To: Shawn Guo <shawnguo@kernel.org>; Mark Brown <broonie@kernel.org>; >> Rafael J. Wysocki <rafael.j.wysocki@intel.com> >> Cc: Oleksij Rempel <o.rempel@pengutronix.de>; kernel@pengutronix.de; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton >> <akpm@linux-foundation.org>; Liam Girdwood <lgirdwood@gmail.com>; >> Leonard Crestez <leonard.crestez@nxp.com>; Rob Herring >> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Michael >> Turquette <mturquette@baylibre.com>; Stephen Boyd >> <sboyd@codeaurora.org>; Fabio Estevam <fabio.estevam@nxp.com>; Russell >> King <linux@armlinux.org.uk>; dl-linux-imx <linux-imx@nxp.com>; Robin Gong >> <yibin.gong@nxp.com>; A.s. Dong <aisheng.dong@nxp.com> >> Subject: [PATCH v8 6/6] ARM: dts: imx6: RIoTboard provide standby on power >> off option >> >> This board, as well as some other boards with i.MX6 and a PMIC, uses a >> "PMIC_STBY_REQ" line to notify the PMIC about a state change. >> The PMIC is programmed for a specific state change before triggering the line. >> In this case, PMIC_STBY_REQ can be used for stand by, sleep and power off >> modes. >> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >> --- >> arch/arm/boot/dts/imx6dl-riotboard.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts >> b/arch/arm/boot/dts/imx6dl-riotboard.dts >> index 2e98c92adff7..a0e9753ee767 100644 >> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts >> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts >> @@ -90,6 +90,10 @@ >> status = "okay"; >> }; >> >> +&clks { >> + fsl,pmic-stby-poweroff; >> +}; > It's better remove the default "syscon-poweroff" power off node. "syscon-poweroff" is by default disabled and not enabled in arch/arm/boot/dts/imx6dl-riotboard.dts
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts index 2e98c92adff7..a0e9753ee767 100644 --- a/arch/arm/boot/dts/imx6dl-riotboard.dts +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts @@ -90,6 +90,10 @@ status = "okay"; }; +&clks { + fsl,pmic-stby-poweroff; +}; + &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; @@ -170,6 +174,7 @@ reg = <0x08>; interrupt-parent = <&gpio5>; interrupts = <16 8>; + fsl,pmic-stby-poweroff; regulators { reg_vddcore: sw1ab { /* VDDARM_IN */
This board, as well as some other boards with i.MX6 and a PMIC, uses a "PMIC_STBY_REQ" line to notify the PMIC about a state change. The PMIC is programmed for a specific state change before triggering the line. In this case, PMIC_STBY_REQ can be used for stand by, sleep and power off modes. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- arch/arm/boot/dts/imx6dl-riotboard.dts | 5 +++++ 1 file changed, 5 insertions(+)