diff mbox

drm/sched: remove unneeded -Iinclude/drm compiler flag

Message ID 1530853931-12061-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive)
State New, archived
Headers show

Commit Message

Masahiro Yamada July 6, 2018, 5:12 a.m. UTC 
I refactored the include directives under include/drm/ some time ago.
This flag is unneeded.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpu/drm/scheduler/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Masahiro Yamada July 28, 2018, 2:43 a.m. UTC | #1 
Hi.

2018-07-06 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> I refactored the include directives under include/drm/ some time ago.
> This flag is unneeded.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Ping?


> ---
>
>  drivers/gpu/drm/scheduler/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile
> index bd0377c..7665883 100644
> --- a/drivers/gpu/drm/scheduler/Makefile
> +++ b/drivers/gpu/drm/scheduler/Makefile
> @@ -20,7 +20,6 @@
>  # OTHER DEALINGS IN THE SOFTWARE.
>  #
>  #
> -ccflags-y := -Iinclude/drm
>  gpu-sched-y := gpu_scheduler.o sched_fence.o
>
>  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> --
> 2.7.4
>
Nayan Deshmukh July 30, 2018, 12:49 p.m. UTC | #2 
On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada <
yamada.masahiro@socionext.com> wrote:

> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com
> >:
> > I refactored the include directives under include/drm/ some time ago.
> > This flag is unneeded.
> >
>
A minor nit-pick in the commit message, something like "With the refactored
include directives under include/drm, this flag is uneeded." might be
better.

> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
With or without that the patch is Acked-by: Nayan Deshmukh <
nayan26deshmukh@gmail.com>

Regards,
Nayan Deshmukh

>
> Ping?
>
>
> > ---
> >
> >  drivers/gpu/drm/scheduler/Makefile | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> >  # OTHER DEALINGS IN THE SOFTWARE.
> >  #
> >  #
> > -ccflags-y := -Iinclude/drm
> >  gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> >  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada &lt;<a href="mailto:yamada.masahiro@socionext.com">yamada.masahiro@socionext.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi.<br>
<br>
2018-07-06 14:12 GMT+09:00 Masahiro Yamada &lt;<a href="mailto:yamada.masahiro@socionext.com" target="_blank">yamada.masahiro@socionext.com</a>&gt;:<br>
&gt; I refactored the include directives under include/drm/ some time ago.<br>
&gt; This flag is unneeded.<br>
&gt;<br></blockquote><div>A minor nit-pick in the commit message, something like &quot;With the 
refactored include directives under include/drm, this flag is uneeded.&quot; 
might be better. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; Signed-off-by: Masahiro Yamada &lt;<a href="mailto:yamada.masahiro@socionext.com" target="_blank">yamada.masahiro@socionext.com</a>&gt;<br></blockquote><div><div>With or without that the patch is Acked-by: Nayan Deshmukh &lt;<a href="mailto:nayan26deshmukh@gmail.com" target="_blank">nayan26deshmukh@gmail.com</a>&gt;<br><br></div><div>Regards,<br></div><div>Nayan Deshmukh <br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Ping?<br>
<br>
<br>
&gt; ---<br>
&gt;<br>
&gt;  drivers/gpu/drm/scheduler/Makefile | 1 -<br>
&gt;  1 file changed, 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile<br>
&gt; index bd0377c..7665883 100644<br>
&gt; --- a/drivers/gpu/drm/scheduler/Makefile<br>
&gt; +++ b/drivers/gpu/drm/scheduler/Makefile<br>
&gt; @@ -20,7 +20,6 @@<br>
&gt;  # OTHER DEALINGS IN THE SOFTWARE.<br>
&gt;  #<br>
&gt;  #<br>
&gt; -ccflags-y := -Iinclude/drm<br>
&gt;  gpu-sched-y := gpu_scheduler.o sched_fence.o<br>
&gt;<br>
&gt;  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o<br>
&gt; --<br>
&gt; 2.7.4<br>
&gt;<br>
<br>
<br>
<br>
-- <br>
Best Regards<br>
Masahiro Yamada<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</blockquote></div></div>
Christian König July 30, 2018, 1:09 p.m. UTC | #3 
Am 30.07.2018 um 14:49 schrieb Nayan Deshmukh:
>
>
> On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada 
> <yamada.masahiro@socionext.com <mailto:yamada.masahiro@socionext.com>> 
> wrote:
>
>     Hi.
>
>     2018-07-06 14:12 GMT+09:00 Masahiro Yamada
>     <yamada.masahiro@socionext.com
>     <mailto:yamada.masahiro@socionext.com>>:
>     > I refactored the include directives under include/drm/ some time
>     ago.
>     > This flag is unneeded.
>     >
>
> A minor nit-pick in the commit message, something like "With the 
> refactored include directives under include/drm, this flag is 
> uneeded." might be better.
>
>     > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com
>     <mailto:yamada.masahiro@socionext.com>>
>
> With or without that the patch is Acked-by: Nayan Deshmukh 
> <nayan26deshmukh@gmail.com <mailto:nayan26deshmukh@gmail.com>>

I've pushed that patch into our internal branch for scheduler work.

Thanks,
Christian.

>
> Regards,
> Nayan Deshmukh
>
>
>     Ping?
>
>
>     > ---
>     >
>     >  drivers/gpu/drm/scheduler/Makefile | 1 -
>     >  1 file changed, 1 deletion(-)
>     >
>     > diff --git a/drivers/gpu/drm/scheduler/Makefile
>     b/drivers/gpu/drm/scheduler/Makefile
>     > index bd0377c..7665883 100644
>     > --- a/drivers/gpu/drm/scheduler/Makefile
>     > +++ b/drivers/gpu/drm/scheduler/Makefile
>     > @@ -20,7 +20,6 @@
>     >  # OTHER DEALINGS IN THE SOFTWARE.
>     >  #
>     >  #
>     > -ccflags-y := -Iinclude/drm
>     >  gpu-sched-y := gpu_scheduler.o sched_fence.o
>     >
>     >  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
>     > --
>     > 2.7.4
>     >
>
>
>
>     -- 
>     Best Regards
>     Masahiro Yamada
>     _______________________________________________
>     dri-devel mailing list
>     dri-devel@lists.freedesktop.org
>     <mailto:dri-devel@lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Am 30.07.2018 um 14:49 schrieb Nayan
      Deshmukh:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAFd4ddxsBsg0gKwW3iCidFRSC+p0VaQFQb=GyAZrgoVVGnDscg@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <div dir="ltr"><br>
        <br>
        <div class="gmail_quote">
          <div dir="ltr">On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada
            &lt;<a href="mailto:yamada.masahiro@socionext.com"
              moz-do-not-send="true">yamada.masahiro@socionext.com</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi.<br>
            <br>
            2018-07-06 14:12 GMT+09:00 Masahiro Yamada &lt;<a
              href="mailto:yamada.masahiro@socionext.com"
              target="_blank" moz-do-not-send="true">yamada.masahiro@socionext.com</a>&gt;:<br>
            &gt; I refactored the include directives under include/drm/
            some time ago.<br>
            &gt; This flag is unneeded.<br>
            &gt;<br>
          </blockquote>
          <div>A minor nit-pick in the commit message, something like
            "With the refactored include directives under include/drm,
            this flag is uneeded." might be better. </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            &gt; Signed-off-by: Masahiro Yamada &lt;<a
              href="mailto:yamada.masahiro@socionext.com"
              target="_blank" moz-do-not-send="true">yamada.masahiro@socionext.com</a>&gt;<br>
          </blockquote>
          <div>
            <div>With or without that the patch is Acked-by: Nayan
              Deshmukh &lt;<a href="mailto:nayan26deshmukh@gmail.com"
                target="_blank" moz-do-not-send="true">nayan26deshmukh@gmail.com</a>&gt;<br>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    I've pushed that patch into our internal branch for scheduler work.<br>
    <br>
    Thanks,<br>
    Christian.<br>
    <br>
    <blockquote type="cite"
cite="mid:CAFd4ddxsBsg0gKwW3iCidFRSC+p0VaQFQb=GyAZrgoVVGnDscg@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_quote">
          <div>
            <div><br>
            </div>
            <div>Regards,<br>
            </div>
            <div>Nayan Deshmukh <br>
            </div>
          </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <br>
            Ping?<br>
            <br>
            <br>
            &gt; ---<br>
            &gt;<br>
            &gt;  drivers/gpu/drm/scheduler/Makefile | 1 -<br>
            &gt;  1 file changed, 1 deletion(-)<br>
            &gt;<br>
            &gt; diff --git a/drivers/gpu/drm/scheduler/Makefile
            b/drivers/gpu/drm/scheduler/Makefile<br>
            &gt; index bd0377c..7665883 100644<br>
            &gt; --- a/drivers/gpu/drm/scheduler/Makefile<br>
            &gt; +++ b/drivers/gpu/drm/scheduler/Makefile<br>
            &gt; @@ -20,7 +20,6 @@<br>
            &gt;  # OTHER DEALINGS IN THE SOFTWARE.<br>
            &gt;  #<br>
            &gt;  #<br>
            &gt; -ccflags-y := -Iinclude/drm<br>
            &gt;  gpu-sched-y := gpu_scheduler.o sched_fence.o<br>
            &gt;<br>
            &gt;  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o<br>
            &gt; --<br>
            &gt; 2.7.4<br>
            &gt;<br>
            <br>
            <br>
            <br>
            -- <br>
            Best Regards<br>
            Masahiro Yamada<br>
            _______________________________________________<br>
            dri-devel mailing list<br>
            <a href="mailto:dri-devel@lists.freedesktop.org"
              target="_blank" moz-do-not-send="true">dri-devel@lists.freedesktop.org</a><br>
            <a
              href="https://lists.freedesktop.org/mailman/listinfo/dri-devel"
              rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
          </blockquote>
        </div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
dri-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/dri-devel">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>
diff mbox

Patch

diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile
index bd0377c..7665883 100644
--- a/drivers/gpu/drm/scheduler/Makefile
+++ b/drivers/gpu/drm/scheduler/Makefile
@@ -20,7 +20,6 @@ 
 # OTHER DEALINGS IN THE SOFTWARE.
 #
 #
-ccflags-y := -Iinclude/drm
 gpu-sched-y := gpu_scheduler.o sched_fence.o
 
 obj-$(CONFIG_DRM_SCHED) += gpu-sched.o