| Message ID | 20180731142157.GA24066@embeddedor.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net/mlx5e: Fix uninitialized variable | expand |
On 31/07/2018 5:21 PM, Gustavo A. R. Silva wrote: > There is a potential execution path in which variable *err* is returned > without being properly initialized previously. > > Fix this by initializing variable *err* to 0. > > Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") > Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index fde3502..de2827a 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -4215,7 +4215,7 @@ static int mlx5e_xdp_set(struct net_device *netdev, struct bpf_prog *prog) > struct mlx5e_priv *priv = netdev_priv(netdev); > struct bpf_prog *old_prog; > bool reset, was_opened; > - int err; > + int err = 0; > int i; > > mutex_lock(&priv->state_lock); > Reviewed-by: Tariq Toukan <tariqt@mellanox.com> Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 31, 2018 at 7:21 AM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > There is a potential execution path in which variable *err* is returned > without being properly initialized previously. > > Fix this by initializing variable *err* to 0. > > Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") > Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Saeed Mahameed <saeedm@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Date: Tue, 31 Jul 2018 09:21:57 -0500 > There is a potential execution path in which variable *err* is returned > without being properly initialized previously. > > Fix this by initializing variable *err* to 0. > > Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") > Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/01/2018 11:38 AM, David Miller wrote: > From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> > Date: Tue, 31 Jul 2018 09:21:57 -0500 > >> There is a potential execution path in which variable *err* is returned >> without being properly initialized previously. >> >> Fix this by initializing variable *err* to 0. >> >> Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") >> Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied to net-next. > David, Sorry I failed to tag this patch for net-next. I got a bit confused, once based on the logs, the usual committer for this driver is Saeed Mahameed; not you. So, I wasn't quite sure about how to proceed. Thanks -- Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index fde3502..de2827a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -4215,7 +4215,7 @@ static int mlx5e_xdp_set(struct net_device *netdev, struct bpf_prog *prog) struct mlx5e_priv *priv = netdev_priv(netdev); struct bpf_prog *old_prog; bool reset, was_opened; - int err; + int err = 0; int i; mutex_lock(&priv->state_lock);
There is a potential execution path in which variable *err* is returned without being properly initialized previously. Fix this by initializing variable *err* to 0. Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)