diff mbox series

[v3,1/3] spi: spi-mem: Fix a typo in the documentation of struct spi_mem

Message ID 1533214434-28761-2-git-send-email-frieder.schrempf@exceet.de (mailing list archive)
State Accepted
Commit 06bcb5168d7d49aa3ed449ff13a6d13c30afc3f0
Headers show
Series Extend the SPI mem interface to set a custom memory name | expand

Commit Message

Frieder Schrempf Aug. 2, 2018, 12:53 p.m. UTC
Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>
---
 include/linux/spi/spi-mem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Boris Brezillon Aug. 2, 2018, 1:09 p.m. UTC | #1
On Thu,  2 Aug 2018 14:53:52 +0200
Frieder Schrempf <frieder.schrempf@exceet.de> wrote:

We usually try to avoid empty commit message, even if this one is
pretty obvious, I'd suggest adding something here.

"
Fix a typo in the @drvpriv description.
"

?

> Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>

Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>

> ---
>  include/linux/spi/spi-mem.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
> index 4fa34a2..72cc9bc 100644
> --- a/include/linux/spi/spi-mem.h
> +++ b/include/linux/spi/spi-mem.h
> @@ -124,7 +124,7 @@ struct spi_mem_op {
>  /**
>   * struct spi_mem - describes a SPI memory device
>   * @spi: the underlying SPI device
> - * @drvpriv: spi_mem_drviver private data
> + * @drvpriv: spi_mem_driver private data
>   *
>   * Extra information that describe the SPI memory device and may be needed by
>   * the controller to properly handle this device should be placed here.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Frieder Schrempf Aug. 2, 2018, 1:39 p.m. UTC | #2
Hi Boris, hi Mark,

On 02.08.2018 15:09, Boris Brezillon wrote:
> On Thu,  2 Aug 2018 14:53:52 +0200
> Frieder Schrempf <frieder.schrempf@exceet.de> wrote:
> 
> We usually try to avoid empty commit message, even if this one is
> pretty obvious, I'd suggest adding something here.
> 
> "
> Fix a typo in the @drvpriv description.
> "
> 
> ?

Forgot the commit message, sorry.

Mark, can you add it when you apply the patch or should I send a new 
version?

Thanks,
Frieder

> 
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>
> 
> Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
> 
>> ---
>>   include/linux/spi/spi-mem.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
>> index 4fa34a2..72cc9bc 100644
>> --- a/include/linux/spi/spi-mem.h
>> +++ b/include/linux/spi/spi-mem.h
>> @@ -124,7 +124,7 @@ struct spi_mem_op {
>>   /**
>>    * struct spi_mem - describes a SPI memory device
>>    * @spi: the underlying SPI device
>> - * @drvpriv: spi_mem_drviver private data
>> + * @drvpriv: spi_mem_driver private data
>>    *
>>    * Extra information that describe the SPI memory device and may be needed by
>>    * the controller to properly handle this device should be placed here.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Aug. 2, 2018, 2:35 p.m. UTC | #3
On Thu, Aug 02, 2018 at 03:39:18PM +0200, Frieder Schrempf wrote:

> Mark, can you add it when you apply the patch or should I send a new
> version?

I'd applied before I saw this subthread, Boris is right that it is
better but for something this obvious I'm not sufficiently bothered by
the missing log.
diff mbox series

Patch

diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
index 4fa34a2..72cc9bc 100644
--- a/include/linux/spi/spi-mem.h
+++ b/include/linux/spi/spi-mem.h
@@ -124,7 +124,7 @@  struct spi_mem_op {
 /**
  * struct spi_mem - describes a SPI memory device
  * @spi: the underlying SPI device
- * @drvpriv: spi_mem_drviver private data
+ * @drvpriv: spi_mem_driver private data
  *
  * Extra information that describe the SPI memory device and may be needed by
  * the controller to properly handle this device should be placed here.