mbox series

[v4,0/4] EDAC: Enhancements to Synopsys EDAC driver

Message ID 1533374735-16662-1-git-send-email-manish.narani@xilinx.com (mailing list archive)
Headers show
Series EDAC: Enhancements to Synopsys EDAC driver | expand

Message

Manish Narani Aug. 4, 2018, 9:25 a.m. UTC 
This patch series enhances the current EDAC driver to support different
platforms.This series adds support for ZynqMP DDRC controller in synopsys
EDAC driver. This series also adds Device tree properties and relevant
binding documentation.

Changes in v2:
	- Moved checking of DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is
	  a feature of ZynqMP DDRC
	- The Binding Documentation in (2/4) is modified as per the review
	  comments

Changes in v3:
	- The commit message in (2/4) is modified (Synopsys EDAC Driver -->
	  ZynqMP DDRC)

Changes in v4:
	- Updated the commit message in (1/4)
	- Renamed function pointer names removing 'synps_' in (1/4)
	- Shortened unnecessary long lines as per the review comment on (1/4)

Manish Narani (4):
  edac: synps: Add platform specific structures for ddrc controller
  dt: bindings: Document ZynqMP DDRC in Synopsys documentation
  edac: synopsys: Add EDAC ECC support for ZynqMP DDRC
  arm64: zynqmp: Add DDRC node

 .../bindings/memory-controllers/synopsys.txt       |  27 +-
 arch/arm64/boot/dts/xilinx/zynqmp.dtsi             |   7 +
 drivers/edac/Kconfig                               |   2 +-
 drivers/edac/synopsys_edac.c                       | 945 ++++++++++++++++++++-
 4 files changed, 941 insertions(+), 40 deletions(-)

Comments

Borislav Petkov Aug. 4, 2018, 4:32 p.m. UTC | #1 
On Sat, Aug 04, 2018 at 02:55:31PM +0530, Manish Narani wrote:
> This patch series enhances the current EDAC driver to support different

This one, your 2/4 and 4/4 still says "this patch". Hurried too much?
How about slowing down and looking at them with a critical eye?

Also, how about waiting for a week before resending your patches so that
you give people chance to review them too?

While you wait, please read Documentation/process/submitting-patches.rst
- it'll help you with the submission modalities.

Thanks.
Manish Narani Aug. 6, 2018, 1:58 p.m. UTC | #2 
Hi Boris,


> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Saturday, August 4, 2018 10:03 PM
> Subject: Re: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver
> 
> On Sat, Aug 04, 2018 at 02:55:31PM +0530, Manish Narani wrote:
> > This patch series enhances the current EDAC driver to support
> > different
> 
> This one, your 2/4 and 4/4 still says "this patch". Hurried too much?
> How about slowing down and looking at them with a critical eye?
> 
> Also, how about waiting for a week before resending your patches so that you
> give people chance to review them too?
> 
> While you wait, please read Documentation/process/submitting-patches.rst
> - it'll help you with the submission modalities.

Yes, I missed it. Sorry for that. I will surely wait for around a week for others to review.
Thanks for the guidance.

Thanks,
Manish Narani