| Message ID | 20180804163818.23360-1-marek.vasut+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bce6d67d035eeaea20dcee12b1362cebde6d9b35 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [V2] ARM: dts: silk: Add DA9063 PMIC node | expand |
Hi Marek, On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote: > Add DA9063 PMIC node to the I2C bus. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Cc: Simon Horman <horms+renesas@verge.net.au> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: linux-renesas-soc@vger.kernel.org > --- > V2: - Replace shmobile with dts since it's a DT patch in subject > - Connect the 9063_IRQ# line to GP3_31 > - Since the DA9063 is connected to both i2c1 and i2c7, connect > it to i2c7, which is the dedicated dvfs i2c. Thanks for the update! > --- a/arch/arm/boot/dts/r8a7794-silk.dts > +++ b/arch/arm/boot/dts/r8a7794-silk.dts > @@ -405,6 +405,23 @@ > clock-frequency = <400000>; > }; > > +&i2c7 { > + status = "okay"; > + clock-frequency = <100000>; > + > + pmic@58 { > + compatible = "dlg,da9063"; > + reg = <0x58>; > + interrupt-parent = <&gpio3>; > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + > + wdt { > + compatible = "dlg,da9063-watchdog"; > + }; Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't you add an rtc subnode? Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey subnode, too? Does that feature work? BTW, Stout also has the onkey wired, but lacks the onkey subnode. > + }; > +}; > + Nevertheless: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Aug 07, 2018 at 10:16:16AM +0200, Geert Uytterhoeven wrote: > Hi Marek, > > On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote: > > Add DA9063 PMIC node to the I2C bus. > > > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Cc: Simon Horman <horms+renesas@verge.net.au> > > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Cc: linux-renesas-soc@vger.kernel.org > > --- > > V2: - Replace shmobile with dts since it's a DT patch in subject > > - Connect the 9063_IRQ# line to GP3_31 > > - Since the DA9063 is connected to both i2c1 and i2c7, connect > > it to i2c7, which is the dedicated dvfs i2c. > > Thanks for the update! > > > --- a/arch/arm/boot/dts/r8a7794-silk.dts > > +++ b/arch/arm/boot/dts/r8a7794-silk.dts > > @@ -405,6 +405,23 @@ > > clock-frequency = <400000>; > > }; > > > > +&i2c7 { > > + status = "okay"; > > + clock-frequency = <100000>; > > + > > + pmic@58 { > > + compatible = "dlg,da9063"; > > + reg = <0x58>; > > + interrupt-parent = <&gpio3>; > > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-controller; > > + > > + wdt { > > + compatible = "dlg,da9063-watchdog"; > > + }; > > Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't > you add an rtc subnode? > > Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey > subnode, too? Does that feature work? > > BTW, Stout also has the onkey wired, but lacks the onkey subnode. > > > + }; > > +}; > > + > > Nevertheless: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have applied this patch for v4.20. Marek, please consider some follow-up patches to address the issues raised by Geert.
On 08/10/2018 01:57 PM, Simon Horman wrote: > On Tue, Aug 07, 2018 at 10:16:16AM +0200, Geert Uytterhoeven wrote: >> Hi Marek, >> >> On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote: >>> Add DA9063 PMIC node to the I2C bus. >>> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >>> Cc: Simon Horman <horms+renesas@verge.net.au> >>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> >>> Cc: linux-renesas-soc@vger.kernel.org >>> --- >>> V2: - Replace shmobile with dts since it's a DT patch in subject >>> - Connect the 9063_IRQ# line to GP3_31 >>> - Since the DA9063 is connected to both i2c1 and i2c7, connect >>> it to i2c7, which is the dedicated dvfs i2c. >> >> Thanks for the update! >> >>> --- a/arch/arm/boot/dts/r8a7794-silk.dts >>> +++ b/arch/arm/boot/dts/r8a7794-silk.dts >>> @@ -405,6 +405,23 @@ >>> clock-frequency = <400000>; >>> }; >>> >>> +&i2c7 { >>> + status = "okay"; >>> + clock-frequency = <100000>; >>> + >>> + pmic@58 { >>> + compatible = "dlg,da9063"; >>> + reg = <0x58>; >>> + interrupt-parent = <&gpio3>; >>> + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; >>> + interrupt-controller; >>> + >>> + wdt { >>> + compatible = "dlg,da9063-watchdog"; >>> + }; >> >> Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't >> you add an rtc subnode? >> >> Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey >> subnode, too? Does that feature work? >> >> BTW, Stout also has the onkey wired, but lacks the onkey subnode. >> >>> + }; >>> +}; >>> + >> >> Nevertheless: >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thanks, I have applied this patch for v4.20. > > Marek, > > please consider some follow-up patches to address the issues > raised by Geert. Thanks for the reminder, I missed the email. Patch is out.
diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts index daec965889d3..6ea60e1faf75 100644 --- a/arch/arm/boot/dts/r8a7794-silk.dts +++ b/arch/arm/boot/dts/r8a7794-silk.dts @@ -405,6 +405,23 @@ clock-frequency = <400000>; }; +&i2c7 { + status = "okay"; + clock-frequency = <100000>; + + pmic@58 { + compatible = "dlg,da9063"; + reg = <0x58>; + interrupt-parent = <&gpio3>; + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; + interrupt-controller; + + wdt { + compatible = "dlg,da9063-watchdog"; + }; + }; +}; + &mmcif0 { pinctrl-0 = <&mmcif0_pins>; pinctrl-names = "default";
Add DA9063 PMIC node to the I2C bus. Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Simon Horman <horms+renesas@verge.net.au> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: linux-renesas-soc@vger.kernel.org --- V2: - Replace shmobile with dts since it's a DT patch in subject - Connect the 9063_IRQ# line to GP3_31 - Since the DA9063 is connected to both i2c1 and i2c7, connect it to i2c7, which is the dedicated dvfs i2c. --- arch/arm/boot/dts/r8a7794-silk.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)