diff mbox series

[1/2] fuse: Use list_first_entry() in flush_bg_queue()

Message ID 153303272510.387.12118866693274687533.stgit@localhost.localdomain (mailing list archive)
State New, archived
Headers show
Series fuse: Small cleanup series | expand

Commit Message

Kirill Tkhai July 31, 2018, 10:25 a.m. UTC 
This cleanup patch makes the function to use the primitive
instead of direct dereferencing.

Also, move fiq dereferencing out of cycle, since it's
always constant.


Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
 fs/fuse/dev.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Miklos Szeredi Aug. 7, 2018, 12:26 p.m. UTC | #1 
On Tue, Jul 31, 2018 at 12:25 PM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
> This cleanup patch makes the function to use the primitive
> instead of direct dereferencing.

Okay.

>
> Also, move fiq dereferencing out of cycle, since it's
> always constant.

Not much win.  The compiler can guess as much...

Applied, anyway.

Thanks,
Miklos
diff mbox series

Patch

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 11ea2c4a38ab..214ce96b1d26 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -353,12 +353,13 @@  void fuse_queue_forget(struct fuse_conn *fc, struct fuse_forget_link *forget,
 
 static void flush_bg_queue(struct fuse_conn *fc)
 {
+	struct fuse_iqueue *fiq = &fc->iq;
+
 	while (fc->active_background < fc->max_background &&
 	       !list_empty(&fc->bg_queue)) {
 		struct fuse_req *req;
-		struct fuse_iqueue *fiq = &fc->iq;
 
-		req = list_entry(fc->bg_queue.next, struct fuse_req, list);
+		req = list_first_entry(&fc->bg_queue, struct fuse_req, list);
 		list_del(&req->list);
 		fc->active_background++;
 		spin_lock(&fiq->waitq.lock);