diff mbox series

scsi: use blk_mq_run_hw_queues in scsi_kick_queue

Message ID 1533709499-1661-1-git-send-email-jianchao.w.wang@oracle.com (mailing list archive)
State Accepted
Headers show
Series scsi: use blk_mq_run_hw_queues in scsi_kick_queue | expand

Commit Message

jianchao.wang Aug. 8, 2018, 6:24 a.m. UTC 
We don't use blk-mq start/stop hw queue any more, so no reason to
use blk_mq_start_hw_queues which does clear_bit, replace it with
blk_mq_run_hw_queues.

Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
---
 drivers/scsi/scsi_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ming Lei Aug. 8, 2018, 9:25 a.m. UTC | #1 
On Wed, Aug 8, 2018 at 2:24 PM, Jianchao Wang
<jianchao.w.wang@oracle.com> wrote:
> We don't use blk-mq start/stop hw queue any more, so no reason to
> use blk_mq_start_hw_queues which does clear_bit, replace it with
> blk_mq_run_hw_queues.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
> ---
>  drivers/scsi/scsi_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 41e9ac9..7de0f26 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -371,7 +371,7 @@ void scsi_device_unbusy(struct scsi_device *sdev)
>  static void scsi_kick_queue(struct request_queue *q)
>  {
>         if (q->mq_ops)
> -               blk_mq_start_hw_queues(q);
> +               blk_mq_run_hw_queues(q, false);
>         else
>                 blk_run_queue(q);
>  }

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks,
Ming Lei
Martin K. Petersen Aug. 9, 2018, 2:02 a.m. UTC | #2 
Jianchao,

> We don't use blk-mq start/stop hw queue any more, so no reason to
> use blk_mq_start_hw_queues which does clear_bit, replace it with
> blk_mq_run_hw_queues.

Applied to 4.19/scsi-queue, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 41e9ac9..7de0f26 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -371,7 +371,7 @@  void scsi_device_unbusy(struct scsi_device *sdev)
 static void scsi_kick_queue(struct request_queue *q)
 {
 	if (q->mq_ops)
-		blk_mq_start_hw_queues(q);
+		blk_mq_run_hw_queues(q, false);
 	else
 		blk_run_queue(q);
 }