| Message ID | 20180808013219.26118-1-ikegami@allied-telesis.co.jp (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: (adt7475) Add error handling for update function | expand |
On Wed, Aug 08, 2018 at 10:32:15AM +0900, Tokunori Ikegami wrote: > Currently the device update function does not care the I2C SMBus error. > This causes a spurious sensor warining detection by sensor application. > To prevent this issue add error handling for the update function. > Also change the show functions to return error pointer value. > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > Cc: linux-hwmon@vger.kernel.org > > Tokunori Ikegami (4): > hwmon: (adt7475) Split device update function to measure and limits > hwmon: (adt7475) Change valid parameter to bool type > hwmon: (adt7475) Change update functions to add error handling > hwmon: (adt7475) Change show functions to return error data correctly > Series applied to hwmon-next. Thanks, Guenter
Hi Guenter-san, Thank you so much for your support. I am very happy with this. Regards, Ikegami > -----Original Message----- > From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter > Roeck > Sent: Saturday, August 11, 2018 1:14 AM > To: IKEGAMI Tokunori > Cc: Jean Delvare; PACKHAM Chris; linux-hwmon@vger.kernel.org > Subject: Re: [PATCH v3 0/4] hwmon: (adt7475) Add error handling for update > function > > On Wed, Aug 08, 2018 at 10:32:15AM +0900, Tokunori Ikegami wrote: > > Currently the device update function does not care the I2C SMBus error. > > This causes a spurious sensor warining detection by sensor application. > > To prevent this issue add error handling for the update function. > > Also change the show functions to return error pointer value. > > > > Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> > > Cc: Guenter Roeck <linux@roeck-us.net> > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > > Cc: linux-hwmon@vger.kernel.org > > > > Tokunori Ikegami (4): > > hwmon: (adt7475) Split device update function to measure and limits > > hwmon: (adt7475) Change valid parameter to bool type > > hwmon: (adt7475) Change update functions to add error handling > > hwmon: (adt7475) Change show functions to return error data correctly > > > > Series applied to hwmon-next. > > Thanks, > Guenter
Currently the device update function does not care the I2C SMBus error. This causes a spurious sensor warining detection by sensor application. To prevent this issue add error handling for the update function. Also change the show functions to return error pointer value. Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> Cc: linux-hwmon@vger.kernel.org Tokunori Ikegami (4): hwmon: (adt7475) Split device update function to measure and limits hwmon: (adt7475) Change valid parameter to bool type hwmon: (adt7475) Change update functions to add error handling hwmon: (adt7475) Change show functions to return error data correctly drivers/hwmon/adt7475.c | 340 ++++++++++++++++++++++++++++++++++-------------- 1 file changed, 244 insertions(+), 96 deletions(-)