| Message ID | 1528984088-24801-2-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 14, 2018 at 03:48:07PM +0200, Geert Uytterhoeven wrote: > With recent dtc and W=1: > > Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a" > Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b" > > Unit addresses are always hexadecimal (without prefix), while the bases > of reg property values depend on their prefixes. > > Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
Hi Geert, On 14/06/18 14:48, Geert Uytterhoeven wrote: > With recent dtc and W=1: > > Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a" > Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b" > > Unit addresses are always hexadecimal (without prefix), while the bases > of reg property values depend on their prefixes. > > Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > index 21ffb5ed818302ff..54d1d3bc186949fa 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -73,7 +73,7 @@ Example: > }; > }; > > - port@10 { > + port@a { > reg = <10>; > > adv7482_txa: endpoint { > @@ -83,7 +83,7 @@ Example: > }; > }; > > - port@11 { > + port@b { > reg = <11>; > > adv7482_txb: endpoint { > Just looking back through these patches, to make sure they get integrated. Having read yours and Robs responses, I do agree that this is a correct fix. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index 21ffb5ed818302ff..54d1d3bc186949fa 100644 --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt @@ -73,7 +73,7 @@ Example: }; }; - port@10 { + port@a { reg = <10>; adv7482_txa: endpoint { @@ -83,7 +83,7 @@ Example: }; }; - port@11 { + port@b { reg = <11>; adv7482_txb: endpoint {
With recent dtc and W=1: Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a" Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b" Unit addresses are always hexadecimal (without prefix), while the bases of reg property values depend on their prefixes. Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)