| Message ID | 1534403799-10594-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: tmio: refactor TMIO core a bit and add UniPhier SD/eMMC controller support | expand |
So, today I did test these patches successfully on a Gen3 board (M3-N) and reviewed half of the patches. I will continue tomorrow with reviewing and testing more boards. In a nutshell, things look good so far.
Hi Wolfram, 2018-08-21 4:07 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>: > > So, today I did test these patches successfully on a Gen3 board (M3-N) > and reviewed half of the patches. I will continue tomorrow with > reviewing and testing more boards. > > In a nutshell, things look good so far. > Thanks for the review! But, this version is not applicable to Linus' tree due to commit db924bba47c80. Resolving the conflict is not trivial. I will rebase and send v3, but I do not understand the quirks Renesas is adding to the TMIO core code.
On 21 August 2018 at 04:57, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Hi Wolfram, > > > 2018-08-21 4:07 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>: >> >> So, today I did test these patches successfully on a Gen3 board (M3-N) >> and reviewed half of the patches. I will continue tomorrow with >> reviewing and testing more boards. >> >> In a nutshell, things look good so far. >> > > > Thanks for the review! > > But, this version is not applicable to Linus' tree > due to commit db924bba47c80. > > Resolving the conflict is not trivial. > > > I will rebase and send v3, > but I do not understand the quirks > Renesas is adding to the TMIO core code. Thanks for the heads up, I am waiting for your v3 then. Kind regards Uffe
Add UniPhier SD/eMMC controller support. As a preparation, I changed tmio_mmc_set_clock() to a platform hook. The clock rate setting is platform-specific, and UniPhier variants will add another way. I thought it would be better to split this to a hook to avoid a mess. Masahiro Yamada (7): mmc: tmio: replace tmio_mmc_clk_stop() calls with tmio_mmc_set_clock() mmc: tmio: move tmio_mmc_set_clock() to platform hook dt-bindings: mmc: add DT binding for UniPhier SD/eMMC controller mmc: uniphier-sd: add UniPhier SD/eMMC controller driver mmc: renesas_sdhi: merge clk_{start,stop} functions to set_clock mmc: renesas_sdhi: refactor CLK_CTL bit calculation mmc: tmio: refactor CLK_CTL bit calculation .../devicetree/bindings/mmc/uniphier-sd.txt | 55 ++ MAINTAINERS | 1 + drivers/mmc/host/Kconfig | 10 + drivers/mmc/host/Makefile | 1 + drivers/mmc/host/renesas_sdhi_core.c | 40 +- drivers/mmc/host/tmio_mmc.c | 56 ++ drivers/mmc/host/tmio_mmc.h | 4 +- drivers/mmc/host/tmio_mmc_core.c | 79 +-- drivers/mmc/host/uniphier-sd.c | 695 +++++++++++++++++++++ 9 files changed, 865 insertions(+), 76 deletions(-) create mode 100644 Documentation/devicetree/bindings/mmc/uniphier-sd.txt create mode 100644 drivers/mmc/host/uniphier-sd.c