[RESEND,0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

Message

Leonard Crestez Aug. 27, 2018, 11:10 a.m. UTC

Adding lcdif nodes to a power domain currently doesn't work, it results
in black/corrupted screens or hangs. While the driver does enable
runtime pm it does not deal correctly with the block being unpowered.

All patches in this series have review tags from a few weeks ago. I'm
resending this today because 4.19 rc1 was released. I'm not sure if this
matters for DRM but in some areas unrelated series get lost during the
merge window.

Marek/Phillip: Is one of you going to pick up these patches?

Link to v4: https://lkml.org/lkml/2018/8/8/573

Leonard Crestez (5):
  drm/mxsfb: Move axi clk enable/disable to crtc enable/disable
  drm/mxsfb: Fix initial corrupt frame when activating display
  drm/mxsfb: Add pm_runtime calls to pipe_enable/disable
  drm/mxsfb: Add PM_SLEEP support
  drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

 drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 53 +++++++++++++++++++-----------
 drivers/gpu/drm/mxsfb/mxsfb_drv.c  | 40 ++++++++++++++++++++++
 2 files changed, 74 insertions(+), 19 deletions(-)

Comments

Philipp Zabel Aug. 27, 2018, 12:02 p.m. UTC | #1

Hi Leonard,

On Mon, 2018-08-27 at 14:10 +0300, Leonard Crestez wrote:
> Adding lcdif nodes to a power domain currently doesn't work, it results
> in black/corrupted screens or hangs. While the driver does enable
> runtime pm it does not deal correctly with the block being unpowered.
> 
> All patches in this series have review tags from a few weeks ago. I'm
> resending this today because 4.19 rc1 was released. I'm not sure if this
> matters for DRM but in some areas unrelated series get lost during the
> merge window.
> 
> Marek/Phillip: Is one of you going to pick up these patches?

I assumed Marek would pick them up.

Marek, should I push these patches to drm-misc-fixes?

regards
Philipp

Leonard Crestez Sept. 3, 2018, 1:51 p.m. UTC | #2

On Mon, 2018-08-27 at 14:02 +0200, Philipp Zabel wrote:
> Hi Leonard,
> 
> On Mon, 2018-08-27 at 14:10 +0300, Leonard Crestez wrote:
> > Adding lcdif nodes to a power domain currently doesn't work, it results
> > in black/corrupted screens or hangs. While the driver does enable
> > runtime pm it does not deal correctly with the block being unpowered.
> > 
> > All patches in this series have review tags from a few weeks ago. I'm
> > resending this today because 4.19 rc1 was released. I'm not sure if this
> > matters for DRM but in some areas unrelated series get lost during the
> > merge window.
> > 
> > Marek/Phillip: Is one of you going to pick up these patches?
> 
> I assumed Marek would pick them up.
> 
> Marek, should I push these patches to drm-misc-fixes?

It's been another week, can't we assume nobody minds if thse patches
are pushed?

--
Regards,
Leonard