diff mbox series

[v2,2/3] arm64: dts: msm8916: Drop model and compatible

Message ID 20180905183517.9390-3-niklas.cassel@linaro.org (mailing list archive)
State Accepted, archived
Delegated to: Andy Gross
Headers show
Series arm msm compatible+model cleanup | expand

Commit Message

Niklas Cassel Sept. 5, 2018, 6:35 p.m. UTC 
DTS board files should always specify model and compatible.

All DTS board files that includes msm8916.dtsi
already specifies model and compatible, and will thus
override the model and compatible in msm8916.dtsi.

Drop model and compatible from msm8916.dtsi,
since they are only a source of confusion.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 ---
 1 file changed, 3 deletions(-)

Comments

Bjorn Andersson Sept. 6, 2018, 3:55 p.m. UTC | #1 
On Wed 05 Sep 11:35 PDT 2018, Niklas Cassel wrote:

> DTS board files should always specify model and compatible.
> 
> All DTS board files that includes msm8916.dtsi
> already specifies model and compatible, and will thus
> override the model and compatible in msm8916.dtsi.
> 
> Drop model and compatible from msm8916.dtsi,
> since they are only a source of confusion.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 7b32b8990d62..726a45960742 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -18,9 +18,6 @@
>  #include <dt-bindings/thermal/thermal.h>
>  
>  / {
> -	model = "Qualcomm Technologies, Inc. MSM8916";
> -	compatible = "qcom,msm8916";
> -
>  	interrupt-parent = <&intc>;
>  
>  	#address-cells = <2>;
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 7b32b8990d62..726a45960742 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -18,9 +18,6 @@ 
 #include <dt-bindings/thermal/thermal.h>
 
 / {
-	model = "Qualcomm Technologies, Inc. MSM8916";
-	compatible = "qcom,msm8916";
-
 	interrupt-parent = <&intc>;
 
 	#address-cells = <2>;