| Message ID | 20180904212237.3078-7-atull@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | fpga: add devm managed create APIs | expand |
On Tue, Sep 04, 2018 at 04:22:35PM -0500, Alan Tull wrote: > fpga_bridge_dev_match() returns a FPGA bridge struct, not a > FPGA manager struct so s/manager/bridge/. > > Signed-off-by: Alan Tull <atull@kernel.org> Acked-by: Moritz Fischer <mdf@kernel.org> > --- > v2: no change in v2 of patchset > --- > drivers/fpga/fpga-bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c > index c39d35f..7b0071a 100644 > --- a/drivers/fpga/fpga-bridge.c > +++ b/drivers/fpga/fpga-bridge.c > @@ -125,7 +125,7 @@ static int fpga_bridge_dev_match(struct device *dev, const void *data) > * > * Given a device, get an exclusive reference to a fpga bridge. > * > - * Return: fpga manager struct or IS_ERR() condition containing error code. > + * Return: fpga bridge struct or IS_ERR() condition containing error code. > */ > struct fpga_bridge *fpga_bridge_get(struct device *dev, > struct fpga_image_info *info) > -- > 2.7.4 > Thanks, Moritz
On Thu, Sep 6, 2018 at 1:43 PM Moritz Fischer <mdf@kernel.org> wrote: Hi Moritz, > > On Tue, Sep 04, 2018 at 04:22:35PM -0500, Alan Tull wrote: > > fpga_bridge_dev_match() returns a FPGA bridge struct, not a > > FPGA manager struct so s/manager/bridge/. > > > > Signed-off-by: Alan Tull <atull@kernel.org> > Acked-by: Moritz Fischer <mdf@kernel.org> Thanks! Alan
diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c index c39d35f..7b0071a 100644 --- a/drivers/fpga/fpga-bridge.c +++ b/drivers/fpga/fpga-bridge.c @@ -125,7 +125,7 @@ static int fpga_bridge_dev_match(struct device *dev, const void *data) * * Given a device, get an exclusive reference to a fpga bridge. * - * Return: fpga manager struct or IS_ERR() condition containing error code. + * Return: fpga bridge struct or IS_ERR() condition containing error code. */ struct fpga_bridge *fpga_bridge_get(struct device *dev, struct fpga_image_info *info)
fpga_bridge_dev_match() returns a FPGA bridge struct, not a FPGA manager struct so s/manager/bridge/. Signed-off-by: Alan Tull <atull@kernel.org> --- v2: no change in v2 of patchset --- drivers/fpga/fpga-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)