| Message ID | 563c7f90-1d9f-440c-4670-8fbebc9f76b0@infradead.org (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | net: wireless: mediatek: fix mt76 LEDS build error | expand |
> From: Randy Dunlap <rdunlap@infradead.org> > > All of the mt76 driver options use its mac80211.o component, > which uses led interfaces, so each of them should depend on > LEDS_CLASS. > > Fixes this build error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init': > drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined reference to `devm_of_led_classdev_register' > > Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") > Hi Randy, a fix for it has been already proposed by Arnd here: https://marc.info/?l=linux-wireless&m=151628136830540&w=2 but it has not been applied yet Regards, Lorenzo
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes: >> From: Randy Dunlap <rdunlap@infradead.org> >> >> All of the mt76 driver options use its mac80211.o component, >> which uses led interfaces, so each of them should depend on >> LEDS_CLASS. >> >> Fixes this build error: >> >> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init': >> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined >> reference to `devm_of_led_classdev_register' >> >> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") >> > > Hi Randy, > > a fix for it has been already proposed by Arnd here: > https://marc.info/?l=linux-wireless&m=151628136830540&w=2 > but it has not been applied yet Yet? Arnd's patch is not on my queue as it's from last January and Felix had a comment for it: https://patchwork.kernel.org/patch/10173197/
Kalle Valo <kvalo@codeaurora.org> writes: > Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes: > >>> From: Randy Dunlap <rdunlap@infradead.org> >>> >>> All of the mt76 driver options use its mac80211.o component, >>> which uses led interfaces, so each of them should depend on >>> LEDS_CLASS. >>> >>> Fixes this build error: >>> >>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init': >>> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined >>> reference to `devm_of_led_classdev_register' >>> >>> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") >>> >> >> Hi Randy, >> >> a fix for it has been already proposed by Arnd here: >> https://marc.info/?l=linux-wireless&m=151628136830540&w=2 >> but it has not been applied yet > > Yet? Arnd's patch is not on my queue as it's from last January and Felix > had a comment for it: > > https://patchwork.kernel.org/patch/10173197/ So what should we do? Arnd hasn't submitted a new patch so should we take this one instead?
On 9/19/18 9:07 AM, Kalle Valo wrote: > Kalle Valo <kvalo@codeaurora.org> writes: > >> Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes: >> >>>> From: Randy Dunlap <rdunlap@infradead.org> >>>> >>>> All of the mt76 driver options use its mac80211.o component, >>>> which uses led interfaces, so each of them should depend on >>>> LEDS_CLASS. >>>> >>>> Fixes this build error: >>>> >>>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init': >>>> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined >>>> reference to `devm_of_led_classdev_register' >>>> >>>> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") >>>> >>> >>> Hi Randy, >>> >>> a fix for it has been already proposed by Arnd here: >>> https://marc.info/?l=linux-wireless&m=151628136830540&w=2 >>> but it has not been applied yet >> >> Yet? Arnd's patch is not on my queue as it's from last January and Felix >> had a comment for it: >> >> https://patchwork.kernel.org/patch/10173197/ > > So what should we do? Arnd hasn't submitted a new patch so should we > take this one instead? No. Arnd, can you resend your patch? thanks,
--- linux-next-20180906.orig/drivers/net/wireless/mediatek/mt76/Kconfig +++ linux-next-20180906/drivers/net/wireless/mediatek/mt76/Kconfig @@ -18,6 +18,7 @@ config MT76x0U tristate "MediaTek MT76x0U (USB) support" select MT76_CORE depends on MAC80211 + depends on LEDS_CLASS depends on USB select MT76x02_LIB help @@ -28,6 +29,7 @@ config MT76x2E select MT76_CORE select MT76x2_COMMON depends on MAC80211 + depends on LEDS_CLASS depends on PCI ---help--- This adds support for MT7612/MT7602/MT7662-based wireless PCIe devices. @@ -38,6 +40,7 @@ config MT76x2U select MT76_USB select MT76x2_COMMON depends on MAC80211 + depends on LEDS_CLASS depends on USB help This adds support for MT7612U-based wireless USB dongles.