| Message ID | 20180908134648.2582-1-noralf@tronnes.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/cma-helper drivers: Use drm_fbdev_generic_setup() | expand |
Hi Noralf. On Sat, Sep 08, 2018 at 03:46:28PM +0200, Noralf Trønnes wrote: > This patchset moves the drivers using the CMA helper fully over to the > generic fbdev emulation. The unused fbdev code is removed from the CMA > helper. The full series looks good. I have browsed all the code changes, and with one minor note where one patch could have been split up all the rest looked good. Feel free to add my: Acked-by: Sam Ravnborg <sam@ravnborg.org> to the full series. > 32 files changed, 56 insertions(+), 492 deletions(-) This kind of diffstat is always a pleasure to see. Especially as in this case where functionality is not removed, just made smarter. I know this set does not include the infrastructure parts, so in reality more lines added. But anyway. Sam
Cc: dri-devel and Sam (sorry about the slip) Den 10.09.2018 14.53, skrev Noralf Trønnes: > > Den 08.09.2018 15.46, skrev Noralf Trønnes: >> This patchset moves the drivers using the CMA helper fully over to the >> generic fbdev emulation. The unused fbdev code is removed from the CMA >> helper. > > Maxime asked for context so I'm replying to all: > > This is the base for this patchset which added > drm_fb_helper_generic_probe, > it was applied in July (now in 4.19): > > drm: Add generic fbdev emulation > https://patchwork.freedesktop.org/series/45848/ > > Noralf. > >> Noralf. >> >> Noralf Trønnes (20): >> drm/fb-helper: Improve error reporting in setup >> drm/arc: Use drm_fbdev_generic_setup() >> drm/fsl-dcu: Use drm_fbdev_generic_setup() >> drm/hisilicon/kirin: Use drm_fbdev_generic_setup() >> drm/meson: Use drm_fbdev_generic_setup() >> drm/mxsfb: Use drm_fbdev_generic_setup() >> drm/rcar-du: Use drm_fbdev_generic_setup() >> drm/arm/hdlcd: Use drm_fbdev_generic_setup() >> drm/arm/mali: Use drm_fbdev_generic_setup() >> drm/atmel-hlcdc: Use drm_fbdev_generic_setup() >> drm/imx: Use drm_fbdev_generic_setup() >> drm/pl111: Use drm_fbdev_generic_setup() >> drm/sti: Use drm_fbdev_generic_setup() >> drm/stm: Use drm_fbdev_generic_setup() >> drm/sun4i: Use drm_fbdev_generic_setup() >> drm/tilcdc: Use drm_fbdev_generic_setup() >> drm/tve200: Use drm_fbdev_generic_setup() >> drm/vc4: Use drm_fbdev_generic_setup() >> drm/zte: Use drm_fbdev_generic_setup() >> drm/cma-helper: Remove unused fbdev code >> >> drivers/gpu/drm/Kconfig | 4 - >> drivers/gpu/drm/arc/arcpgu.h | 4 - >> drivers/gpu/drm/arc/arcpgu_drv.c | 33 +----- >> drivers/gpu/drm/arm/hdlcd_drv.c | 11 +- >> drivers/gpu/drm/arm/malidp_drv.c | 11 +- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +- >> drivers/gpu/drm/drm_fb_cma_helper.c | 151 >> ------------------------ >> drivers/gpu/drm/drm_fb_helper.c | 8 +- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 25 +--- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 1 - >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 38 +----- >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 4 - >> drivers/gpu/drm/imx/imx-drm-core.c | 19 +-- >> drivers/gpu/drm/meson/meson_drv.c | 19 +-- >> drivers/gpu/drm/meson/meson_drv.h | 1 - >> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 +--- >> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 1 - >> drivers/gpu/drm/pl111/pl111_drv.c | 6 +- >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 34 +----- >> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 3 - >> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 21 ---- >> drivers/gpu/drm/sti/sti_drv.c | 8 +- >> drivers/gpu/drm/stm/drv.c | 11 +- >> drivers/gpu/drm/sun4i/sun4i_drv.c | 12 +- >> drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 12 +- >> drivers/gpu/drm/sun4i/sun4i_framebuffer.h | 3 +- >> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 +- >> drivers/gpu/drm/tve200/tve200_drv.c | 14 +-- >> drivers/gpu/drm/vc4/vc4_drv.c | 5 +- >> drivers/gpu/drm/vc4/vc4_kms.c | 6 - >> drivers/gpu/drm/zte/zx_drm_drv.c | 15 +-- >> include/drm/drm_fb_cma_helper.h | 24 ---- >> 32 files changed, 56 insertions(+), 492 deletions(-) >> >