| Message ID | 20180912011956.32205-1-jose.souza@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS | expand |
On Tue, Sep 11, 2018 at 06:19:56PM -0700, José Roberto de Souza wrote: > Without this gem will not be able to turn off DC states to redunce > interruption latency when no sink is being driven by driver. Do we know that for sure this is still required? Some kind of test results to confirm would be nice. > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c > index 480dadb1047b..af8a0b6ee79b 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -1978,6 +1978,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv, > */ > #define ICL_DISPLAY_DC_OFF_POWER_DOMAINS ( \ > ICL_PW_2_POWER_DOMAINS | \ > + BIT_ULL(POWER_DOMAIN_GT_IRQ) | \ > BIT_ULL(POWER_DOMAIN_MODESET) | \ > BIT_ULL(POWER_DOMAIN_AUX_A) | \ > BIT_ULL(POWER_DOMAIN_INIT)) > -- > 2.18.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Ville Syrjälä (2018-09-12 13:48:42) > On Tue, Sep 11, 2018 at 06:19:56PM -0700, José Roberto de Souza wrote: > > Without this gem will not be able to turn off DC states to redunce > > interruption latency when no sink is being driven by driver. > > Do we know that for sure this is still required? Some kind of test > results to confirm would be nice. After all it was working around a bug in the dmc that was meant to be fixed at some point in the future. -Chris
On Wed, 2018-09-12 at 13:55 +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-09-12 13:48:42) > > On Tue, Sep 11, 2018 at 06:19:56PM -0700, José Roberto de Souza > > wrote: > > > Without this gem will not be able to turn off DC states to > > > redunce > > > interruption latency when no sink is being driven by driver. > > > > Do we know that for sure this is still required? Some kind of test > > results to confirm would be nice. I'm not sure if is still needed, I just saw that older platforms have that domain in DC off and it is used by gem but ICL don't have it set. Also we are still not loading DMC firmware for ICL so it will not be reproducible until that but I guess is better already be prepared and keep consistent with other platforms. > > After all it was working around a bug in the dmc that was meant to be > fixed at some point in the future. > -Chris
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 480dadb1047b..af8a0b6ee79b 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -1978,6 +1978,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv, */ #define ICL_DISPLAY_DC_OFF_POWER_DOMAINS ( \ ICL_PW_2_POWER_DOMAINS | \ + BIT_ULL(POWER_DOMAIN_GT_IRQ) | \ BIT_ULL(POWER_DOMAIN_MODESET) | \ BIT_ULL(POWER_DOMAIN_AUX_A) | \ BIT_ULL(POWER_DOMAIN_INIT))
Without this gem will not be able to turn off DC states to redunce interruption latency when no sink is being driven by driver. Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/intel_runtime_pm.c | 1 + 1 file changed, 1 insertion(+)