| Message ID | 20180912212942.19641-1-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | V4L2 fwnode rework; support for default configuration | expand |
Hi Sakari, On Thu, Sep 13, 2018 at 12:29:19AM +0300, Sakari Ailus wrote: > Hello everyone, > > I've long thought the V4L2 fwnode framework requires some work (it's buggy > and it does not adequately serve common needs). This set should address in > particular these matters: > > - Most devices support a particular media bus type but the V4L2 fwnode > framework was not able to use such information, but instead tried to > guess the bus type with varying levels of success while drivers > generally ignored the results. This patchset makes that possible --- > setting a bus type enables parsing configuration for only that bus. > Failing that check results in returning -ENXIO to be returned. > > - Support specifying default configuration. If the endpoint has no > configuration, the defaults set by the driver (as documented in DT > bindings) will prevail. Any available configuration will still be read > from the endpoint as one could expect. A common use case for this is > e.g. the number of CSI-2 lanes. Few devices support lane mapping, and > default 1:1 mapping is provided in absence of a valid default or > configuration read OF. > > - Debugging information is greatly improved. > > - Recognition of the differences between CSI-2 D-PHY and C-PHY. All > currently supported hardware (or at least drivers) is D-PHY only, so > this change is still easy. > > The smiapp driver is converted to use the new functionality. This patchset > does not address remaining issues such as supporting setting defaults for > e.g. bridge drivers with multiple ports, but with Steve Longerbeam's > patchset we're much closer to that goal. I've rebased this set on top of > Steve's. Albeit the two deal with the same files, there were only a few > trivial conflicts. > > Note that I've only tested parsing endpoints for the CSI-2 bus (no > parallel IF hardware). Jacopo has tested an earlier version of the set > with a few changes to the parallel bus handling compared to this one. I've tested on parallel bus with CEU and MT9V111. You can add my: Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org> to this version too. Thanks j > > Comments are welcome. > > I've pushed the patches (including Steve's) here: > > <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=v4l2-fwnode-next> > > since v1: > > - Rebase it all on current media tree master --- there was a conflict in > drivers/media/platform/qcom/camss/camss.c in Steve's patch "media: > platform: Switch to v4l2_async_notifier_add_subdev"; I hope the > resolution was fine. > > - Default to Bt.656 bus in guessing the bus type if no properties > suggesting otherwise are set. In v1 and error was returned, which would > have been troublesome for the existing drivers. > > - Set the bus_type field to zero (i.e. guess) for existing callers of > v4l2_fwnode_endpoint_(alloc_)parse. > > - Improved documentation for v4l2_fwnode_endpoint_parse and > v4l2_fwnode_endpoint_alloc_parse. > > since v2: > > - Rename V4L2_MBUS_CSI2 to V4L2_MBUS_CSI2_DPHY also in > drivers/gpu/ipu-v3/ipu-csi.c. > > - Use 0 instead of V4L2_MBUS_UNKNOWN in > v4l2_async_notifier_fwnode_parse_endpoint(). This is partially due to > V4L2_MBUS_UNKNOWN being introduced after the change is done. > > - Initialise bus_type to zero in quite a few V4L2 fwnode endpoints in > drivers/staging/media/imx/imx-media-csi.c (thanks to Steve for the > changes). > > Sakari Ailus (23): > v4l: fwnode: Add debug prints for V4L2 endpoint property parsing > v4l: fwnode: Use fwnode_graph_for_each_endpoint > v4l: fwnode: The CSI-2 clock is continuous if it's not non-continuous > dt-bindings: media: Specify bus type for MIPI D-PHY, others, > explicitly > v4l: fwnode: Add definitions for CSI-2 D-PHY, parallel and Bt.656 > busses > v4l: mediabus: Recognise CSI-2 D-PHY and C-PHY > v4l: fwnode: Let the caller provide V4L2 fwnode endpoint > v4l: fwnode: Detect bus type correctly > v4l: fwnode: Make use of newly specified bus types > v4l: fwnode: Read lane inversion information despite lane numbering > v4l: fwnode: Only assign configuration if there is no error > v4l: fwnode: Support driver-defined lane mapping defaults > v4l: fwnode: Support default CSI-2 lane mapping for drivers > v4l: fwnode: Parse the graph endpoint as last > v4l: fwnode: Use default parallel flags > v4l: fwnode: Initialise the V4L2 fwnode endpoints to zero > v4l: fwnode: Only zero the struct if bus type is set to > V4L2_MBUS_UNKNOWN > v4l: fwnode: Use media bus type for bus parser selection > v4l: fwnode: Print bus type > v4l: fwnode: Use V4L2 fwnode endpoint media bus type if set > v4l: fwnode: Support parsing of CSI-2 C-PHY endpoints > v4l: fwnode: Update V4L2 fwnode endpoint parsing documentation > smiapp: Query the V4L2 endpoint for a specific bus type > > .../devicetree/bindings/media/video-interfaces.txt | 4 +- > drivers/gpu/ipu-v3/ipu-csi.c | 6 +- > drivers/media/i2c/adv7180.c | 2 +- > drivers/media/i2c/adv7604.c | 2 +- > drivers/media/i2c/mt9v032.c | 2 +- > drivers/media/i2c/ov2659.c | 14 +- > drivers/media/i2c/ov5640.c | 4 +- > drivers/media/i2c/ov5645.c | 2 +- > drivers/media/i2c/ov5647.c | 2 +- > drivers/media/i2c/ov7251.c | 4 +- > drivers/media/i2c/ov7670.c | 2 +- > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 4 +- > drivers/media/i2c/s5k5baf.c | 6 +- > drivers/media/i2c/s5k6aa.c | 2 +- > drivers/media/i2c/smiapp/smiapp-core.c | 34 +- > drivers/media/i2c/soc_camera/ov5642.c | 2 +- > drivers/media/i2c/tc358743.c | 28 +- > drivers/media/i2c/tda1997x.c | 2 +- > drivers/media/i2c/tvp514x.c | 2 +- > drivers/media/i2c/tvp5150.c | 2 +- > drivers/media/i2c/tvp7002.c | 2 +- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- > drivers/media/platform/am437x/am437x-vpfe.c | 2 +- > drivers/media/platform/atmel/atmel-isc.c | 3 +- > drivers/media/platform/atmel/atmel-isi.c | 2 +- > drivers/media/platform/cadence/cdns-csi2rx.c | 4 +- > drivers/media/platform/cadence/cdns-csi2tx.c | 4 +- > drivers/media/platform/davinci/vpif_capture.c | 2 +- > drivers/media/platform/exynos4-is/media-dev.c | 2 +- > drivers/media/platform/exynos4-is/mipi-csis.c | 2 +- > drivers/media/platform/marvell-ccic/mcam-core.c | 4 +- > drivers/media/platform/marvell-ccic/mmp-driver.c | 2 +- > drivers/media/platform/omap3isp/isp.c | 2 +- > drivers/media/platform/pxa_camera.c | 4 +- > drivers/media/platform/rcar-vin/rcar-csi2.c | 4 +- > drivers/media/platform/renesas-ceu.c | 3 +- > drivers/media/platform/soc_camera/soc_mediabus.c | 2 +- > drivers/media/platform/stm32/stm32-dcmi.c | 4 +- > drivers/media/platform/ti-vpe/cal.c | 2 +- > drivers/media/v4l2-core/v4l2-fwnode.c | 508 ++++++++++++++++----- > drivers/staging/media/imx/imx-media-csi.c | 10 +- > drivers/staging/media/imx/imx6-mipi-csi2.c | 2 +- > drivers/staging/media/imx074/imx074.c | 2 +- > include/media/v4l2-fwnode.h | 60 ++- > include/media/v4l2-mediabus.h | 8 +- > 45 files changed, 542 insertions(+), 226 deletions(-) > > -- > 2.11.0 >
On Thu, Sep 13, 2018 at 11:54:50AM +0200, jacopo mondi wrote: > Hi Sakari, > > On Thu, Sep 13, 2018 at 12:29:19AM +0300, Sakari Ailus wrote: > > Hello everyone, > > > > I've long thought the V4L2 fwnode framework requires some work (it's buggy > > and it does not adequately serve common needs). This set should address in > > particular these matters: > > > > - Most devices support a particular media bus type but the V4L2 fwnode > > framework was not able to use such information, but instead tried to > > guess the bus type with varying levels of success while drivers > > generally ignored the results. This patchset makes that possible --- > > setting a bus type enables parsing configuration for only that bus. > > Failing that check results in returning -ENXIO to be returned. > > > > - Support specifying default configuration. If the endpoint has no > > configuration, the defaults set by the driver (as documented in DT > > bindings) will prevail. Any available configuration will still be read > > from the endpoint as one could expect. A common use case for this is > > e.g. the number of CSI-2 lanes. Few devices support lane mapping, and > > default 1:1 mapping is provided in absence of a valid default or > > configuration read OF. > > > > - Debugging information is greatly improved. > > > > - Recognition of the differences between CSI-2 D-PHY and C-PHY. All > > currently supported hardware (or at least drivers) is D-PHY only, so > > this change is still easy. > > > > The smiapp driver is converted to use the new functionality. This patchset > > does not address remaining issues such as supporting setting defaults for > > e.g. bridge drivers with multiple ports, but with Steve Longerbeam's > > patchset we're much closer to that goal. I've rebased this set on top of > > Steve's. Albeit the two deal with the same files, there were only a few > > trivial conflicts. > > > > Note that I've only tested parsing endpoints for the CSI-2 bus (no > > parallel IF hardware). Jacopo has tested an earlier version of the set > > with a few changes to the parallel bus handling compared to this one. > > I've tested on parallel bus with CEU and MT9V111. > > You can add my: > Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > to this version too. Thanks! I'll put your ack on the DT binding documentation patch as Tested-by: isn't really meaningful in that case.
Hello everyone, I've long thought the V4L2 fwnode framework requires some work (it's buggy and it does not adequately serve common needs). This set should address in particular these matters: - Most devices support a particular media bus type but the V4L2 fwnode framework was not able to use such information, but instead tried to guess the bus type with varying levels of success while drivers generally ignored the results. This patchset makes that possible --- setting a bus type enables parsing configuration for only that bus. Failing that check results in returning -ENXIO to be returned. - Support specifying default configuration. If the endpoint has no configuration, the defaults set by the driver (as documented in DT bindings) will prevail. Any available configuration will still be read from the endpoint as one could expect. A common use case for this is e.g. the number of CSI-2 lanes. Few devices support lane mapping, and default 1:1 mapping is provided in absence of a valid default or configuration read OF. - Debugging information is greatly improved. - Recognition of the differences between CSI-2 D-PHY and C-PHY. All currently supported hardware (or at least drivers) is D-PHY only, so this change is still easy. The smiapp driver is converted to use the new functionality. This patchset does not address remaining issues such as supporting setting defaults for e.g. bridge drivers with multiple ports, but with Steve Longerbeam's patchset we're much closer to that goal. I've rebased this set on top of Steve's. Albeit the two deal with the same files, there were only a few trivial conflicts. Note that I've only tested parsing endpoints for the CSI-2 bus (no parallel IF hardware). Jacopo has tested an earlier version of the set with a few changes to the parallel bus handling compared to this one. Comments are welcome. I've pushed the patches (including Steve's) here: <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=v4l2-fwnode-next> since v1: - Rebase it all on current media tree master --- there was a conflict in drivers/media/platform/qcom/camss/camss.c in Steve's patch "media: platform: Switch to v4l2_async_notifier_add_subdev"; I hope the resolution was fine. - Default to Bt.656 bus in guessing the bus type if no properties suggesting otherwise are set. In v1 and error was returned, which would have been troublesome for the existing drivers. - Set the bus_type field to zero (i.e. guess) for existing callers of v4l2_fwnode_endpoint_(alloc_)parse. - Improved documentation for v4l2_fwnode_endpoint_parse and v4l2_fwnode_endpoint_alloc_parse. since v2: - Rename V4L2_MBUS_CSI2 to V4L2_MBUS_CSI2_DPHY also in drivers/gpu/ipu-v3/ipu-csi.c. - Use 0 instead of V4L2_MBUS_UNKNOWN in v4l2_async_notifier_fwnode_parse_endpoint(). This is partially due to V4L2_MBUS_UNKNOWN being introduced after the change is done. - Initialise bus_type to zero in quite a few V4L2 fwnode endpoints in drivers/staging/media/imx/imx-media-csi.c (thanks to Steve for the changes). Sakari Ailus (23): v4l: fwnode: Add debug prints for V4L2 endpoint property parsing v4l: fwnode: Use fwnode_graph_for_each_endpoint v4l: fwnode: The CSI-2 clock is continuous if it's not non-continuous dt-bindings: media: Specify bus type for MIPI D-PHY, others, explicitly v4l: fwnode: Add definitions for CSI-2 D-PHY, parallel and Bt.656 busses v4l: mediabus: Recognise CSI-2 D-PHY and C-PHY v4l: fwnode: Let the caller provide V4L2 fwnode endpoint v4l: fwnode: Detect bus type correctly v4l: fwnode: Make use of newly specified bus types v4l: fwnode: Read lane inversion information despite lane numbering v4l: fwnode: Only assign configuration if there is no error v4l: fwnode: Support driver-defined lane mapping defaults v4l: fwnode: Support default CSI-2 lane mapping for drivers v4l: fwnode: Parse the graph endpoint as last v4l: fwnode: Use default parallel flags v4l: fwnode: Initialise the V4L2 fwnode endpoints to zero v4l: fwnode: Only zero the struct if bus type is set to V4L2_MBUS_UNKNOWN v4l: fwnode: Use media bus type for bus parser selection v4l: fwnode: Print bus type v4l: fwnode: Use V4L2 fwnode endpoint media bus type if set v4l: fwnode: Support parsing of CSI-2 C-PHY endpoints v4l: fwnode: Update V4L2 fwnode endpoint parsing documentation smiapp: Query the V4L2 endpoint for a specific bus type .../devicetree/bindings/media/video-interfaces.txt | 4 +- drivers/gpu/ipu-v3/ipu-csi.c | 6 +- drivers/media/i2c/adv7180.c | 2 +- drivers/media/i2c/adv7604.c | 2 +- drivers/media/i2c/mt9v032.c | 2 +- drivers/media/i2c/ov2659.c | 14 +- drivers/media/i2c/ov5640.c | 4 +- drivers/media/i2c/ov5645.c | 2 +- drivers/media/i2c/ov5647.c | 2 +- drivers/media/i2c/ov7251.c | 4 +- drivers/media/i2c/ov7670.c | 2 +- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 4 +- drivers/media/i2c/s5k5baf.c | 6 +- drivers/media/i2c/s5k6aa.c | 2 +- drivers/media/i2c/smiapp/smiapp-core.c | 34 +- drivers/media/i2c/soc_camera/ov5642.c | 2 +- drivers/media/i2c/tc358743.c | 28 +- drivers/media/i2c/tda1997x.c | 2 +- drivers/media/i2c/tvp514x.c | 2 +- drivers/media/i2c/tvp5150.c | 2 +- drivers/media/i2c/tvp7002.c | 2 +- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- drivers/media/platform/am437x/am437x-vpfe.c | 2 +- drivers/media/platform/atmel/atmel-isc.c | 3 +- drivers/media/platform/atmel/atmel-isi.c | 2 +- drivers/media/platform/cadence/cdns-csi2rx.c | 4 +- drivers/media/platform/cadence/cdns-csi2tx.c | 4 +- drivers/media/platform/davinci/vpif_capture.c | 2 +- drivers/media/platform/exynos4-is/media-dev.c | 2 +- drivers/media/platform/exynos4-is/mipi-csis.c | 2 +- drivers/media/platform/marvell-ccic/mcam-core.c | 4 +- drivers/media/platform/marvell-ccic/mmp-driver.c | 2 +- drivers/media/platform/omap3isp/isp.c | 2 +- drivers/media/platform/pxa_camera.c | 4 +- drivers/media/platform/rcar-vin/rcar-csi2.c | 4 +- drivers/media/platform/renesas-ceu.c | 3 +- drivers/media/platform/soc_camera/soc_mediabus.c | 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 4 +- drivers/media/platform/ti-vpe/cal.c | 2 +- drivers/media/v4l2-core/v4l2-fwnode.c | 508 ++++++++++++++++----- drivers/staging/media/imx/imx-media-csi.c | 10 +- drivers/staging/media/imx/imx6-mipi-csi2.c | 2 +- drivers/staging/media/imx074/imx074.c | 2 +- include/media/v4l2-fwnode.h | 60 ++- include/media/v4l2-mediabus.h | 8 +- 45 files changed, 542 insertions(+), 226 deletions(-)