mbox series

[v3,RESEND,0/4] clk: clk: Add functions to save/restore clock context en-masse

Message ID 1536043778-2232-1-git-send-email-j-keerthy@ti.com (mailing list archive)
Headers show
Series clk: clk: Add functions to save/restore clock context en-masse | expand

Message

J, KEERTHY Sept. 4, 2018, 6:49 a.m. UTC
Deep enough power saving mode can result into losing context of the clock
registers also, and they need to be restored once coming back from the power
saving mode. Hence add functions to save/restore clock context.

Tested for DS0 on am437x-gp-evm

Based on top of linux-next

Resend Series:

  * Rebased on top of Linux 4.19-rc2
  * Added Tony's Ack.

Changes in v2:

        * Renamed clk_dflt_restore to clk_gate_restore_context

Changes in v3: Corrected the e-mail address of linux-omap list 

Keerthy (2):
  clk: clk: Add clk_gate_restore_context function
  ti: pm33xx: Save/restore clk context based on enable_off_mode setting

Russ Dill (2):
  clk: clk: Add functions to save/restore clock context en-masse
  clk: ti: Add functions to save/restore clk context

 arch/arm/mach-omap2/pm33xx-core.c    |  15 +++++
 drivers/clk/clk.c                    |  93 ++++++++++++++++++++++++++
 drivers/clk/ti/clock.h               |   2 +
 drivers/clk/ti/divider.c             |  36 ++++++++++
 drivers/clk/ti/dpll.c                |   6 ++
 drivers/clk/ti/dpll3xxx.c            | 124 +++++++++++++++++++++++++++++++++++
 drivers/clk/ti/gate.c                |   3 +
 drivers/clk/ti/mux.c                 |  29 ++++++++
 drivers/soc/ti/pm33xx.c              |  13 ++++
 include/linux/clk-provider.h         |   9 +++
 include/linux/clk.h                  |  25 +++++++
 include/linux/clk/ti.h               |   6 ++
 include/linux/platform_data/pm33xx.h |   1 +
 13 files changed, 362 insertions(+)

Comments

J, KEERTHY Sept. 19, 2018, 7:50 a.m. UTC | #1
On Tuesday 04 September 2018 12:19 PM, Keerthy wrote:
> Deep enough power saving mode can result into losing context of the clock
> registers also, and they need to be restored once coming back from the power
> saving mode. Hence add functions to save/restore clock context.

A gentle ping on this series.

> 
> Tested for DS0 on am437x-gp-evm
> 
> Based on top of linux-next
> 
> Resend Series:
> 
>   * Rebased on top of Linux 4.19-rc2
>   * Added Tony's Ack.
> 
> Changes in v2:
> 
>         * Renamed clk_dflt_restore to clk_gate_restore_context
> 
> Changes in v3: Corrected the e-mail address of linux-omap list 
> 
> Keerthy (2):
>   clk: clk: Add clk_gate_restore_context function
>   ti: pm33xx: Save/restore clk context based on enable_off_mode setting
> 
> Russ Dill (2):
>   clk: clk: Add functions to save/restore clock context en-masse
>   clk: ti: Add functions to save/restore clk context
> 
>  arch/arm/mach-omap2/pm33xx-core.c    |  15 +++++
>  drivers/clk/clk.c                    |  93 ++++++++++++++++++++++++++
>  drivers/clk/ti/clock.h               |   2 +
>  drivers/clk/ti/divider.c             |  36 ++++++++++
>  drivers/clk/ti/dpll.c                |   6 ++
>  drivers/clk/ti/dpll3xxx.c            | 124 +++++++++++++++++++++++++++++++++++
>  drivers/clk/ti/gate.c                |   3 +
>  drivers/clk/ti/mux.c                 |  29 ++++++++
>  drivers/soc/ti/pm33xx.c              |  13 ++++
>  include/linux/clk-provider.h         |   9 +++
>  include/linux/clk.h                  |  25 +++++++
>  include/linux/clk/ti.h               |   6 ++
>  include/linux/platform_data/pm33xx.h |   1 +
>  13 files changed, 362 insertions(+)
>
Tero Kristo Sept. 19, 2018, 9:26 a.m. UTC | #2
On 19/09/18 10:50, Keerthy wrote:
> 
> 
> On Tuesday 04 September 2018 12:19 PM, Keerthy wrote:
>> Deep enough power saving mode can result into losing context of the clock
>> registers also, and they need to be restored once coming back from the power
>> saving mode. Hence add functions to save/restore clock context.
> 
> A gentle ping on this series.

Stephen,

what is your take on this? I can pick this up as part of my changes for 
4.20 and send a pull-req, however it contains changes to clock core so I 
am somewhat hesitant to do that.

-Tero

> 
>>
>> Tested for DS0 on am437x-gp-evm
>>
>> Based on top of linux-next
>>
>> Resend Series:
>>
>>    * Rebased on top of Linux 4.19-rc2
>>    * Added Tony's Ack.
>>
>> Changes in v2:
>>
>>          * Renamed clk_dflt_restore to clk_gate_restore_context
>>
>> Changes in v3: Corrected the e-mail address of linux-omap list
>>
>> Keerthy (2):
>>    clk: clk: Add clk_gate_restore_context function
>>    ti: pm33xx: Save/restore clk context based on enable_off_mode setting
>>
>> Russ Dill (2):
>>    clk: clk: Add functions to save/restore clock context en-masse
>>    clk: ti: Add functions to save/restore clk context
>>
>>   arch/arm/mach-omap2/pm33xx-core.c    |  15 +++++
>>   drivers/clk/clk.c                    |  93 ++++++++++++++++++++++++++
>>   drivers/clk/ti/clock.h               |   2 +
>>   drivers/clk/ti/divider.c             |  36 ++++++++++
>>   drivers/clk/ti/dpll.c                |   6 ++
>>   drivers/clk/ti/dpll3xxx.c            | 124 +++++++++++++++++++++++++++++++++++
>>   drivers/clk/ti/gate.c                |   3 +
>>   drivers/clk/ti/mux.c                 |  29 ++++++++
>>   drivers/soc/ti/pm33xx.c              |  13 ++++
>>   include/linux/clk-provider.h         |   9 +++
>>   include/linux/clk.h                  |  25 +++++++
>>   include/linux/clk/ti.h               |   6 ++
>>   include/linux/platform_data/pm33xx.h |   1 +
>>   13 files changed, 362 insertions(+)
>>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Tero Kristo Oct. 3, 2018, 12:38 p.m. UTC | #3
Hi Keerthy,

Queuing the three clock patches for 4.20 (assuming these can still fit 
in), the pm33xx related patch should be picked up by Tony.

-Tero

On 04/09/18 09:49, Keerthy wrote:
> Deep enough power saving mode can result into losing context of the clock
> registers also, and they need to be restored once coming back from the power
> saving mode. Hence add functions to save/restore clock context.
> 
> Tested for DS0 on am437x-gp-evm
> 
> Based on top of linux-next
> 
> Resend Series:
> 
>    * Rebased on top of Linux 4.19-rc2
>    * Added Tony's Ack.
> 
> Changes in v2:
> 
>          * Renamed clk_dflt_restore to clk_gate_restore_context
> 
> Changes in v3: Corrected the e-mail address of linux-omap list
> 
> Keerthy (2):
>    clk: clk: Add clk_gate_restore_context function
>    ti: pm33xx: Save/restore clk context based on enable_off_mode setting
> 
> Russ Dill (2):
>    clk: clk: Add functions to save/restore clock context en-masse
>    clk: ti: Add functions to save/restore clk context
> 
>   arch/arm/mach-omap2/pm33xx-core.c    |  15 +++++
>   drivers/clk/clk.c                    |  93 ++++++++++++++++++++++++++
>   drivers/clk/ti/clock.h               |   2 +
>   drivers/clk/ti/divider.c             |  36 ++++++++++
>   drivers/clk/ti/dpll.c                |   6 ++
>   drivers/clk/ti/dpll3xxx.c            | 124 +++++++++++++++++++++++++++++++++++
>   drivers/clk/ti/gate.c                |   3 +
>   drivers/clk/ti/mux.c                 |  29 ++++++++
>   drivers/soc/ti/pm33xx.c              |  13 ++++
>   include/linux/clk-provider.h         |   9 +++
>   include/linux/clk.h                  |  25 +++++++
>   include/linux/clk/ti.h               |   6 ++
>   include/linux/platform_data/pm33xx.h |   1 +
>   13 files changed, 362 insertions(+)
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki