| Message ID | 20180921230444.GA2713@sigill.intra.peff.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | receive-pack: update comment with check_everything_connected | expand |
Jeff King <peff@peff.net> writes: > That function is now called "check_connected()", but we forgot to update > this comment in 7043c7071c (check_everything_connected: use a struct > with named options, 2016-07-15). > > Signed-off-by: Jeff King <peff@peff.net> > --- > Just a minor annoyance I happened to notice while discussing in another > thread. I notice both of us still called it check-everything-connected > in our emails; old habits die hard, I suppose. ;) Yup, and now I think I caught up ;-) Thanks. > > builtin/receive-pack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c > index a3bb13af10..3b7432c8e4 100644 > --- a/builtin/receive-pack.c > +++ b/builtin/receive-pack.c > @@ -1834,7 +1834,7 @@ static void prepare_shallow_update(struct command *commands, > /* > * keep hooks happy by forcing a temporary shallow file via > * env variable because we can't add --shallow-file to every > - * command. check_everything_connected() will be done with > + * command. check_connected() will be done with > * true .git/shallow though. > */ > setenv(GIT_SHALLOW_FILE_ENVIRONMENT, alt_shallow_file, 1);
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index a3bb13af10..3b7432c8e4 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -1834,7 +1834,7 @@ static void prepare_shallow_update(struct command *commands, /* * keep hooks happy by forcing a temporary shallow file via * env variable because we can't add --shallow-file to every - * command. check_everything_connected() will be done with + * command. check_connected() will be done with * true .git/shallow though. */ setenv(GIT_SHALLOW_FILE_ENVIRONMENT, alt_shallow_file, 1);
That function is now called "check_connected()", but we forgot to update this comment in 7043c7071c (check_everything_connected: use a struct with named options, 2016-07-15). Signed-off-by: Jeff King <peff@peff.net> --- Just a minor annoyance I happened to notice while discussing in another thread. I notice both of us still called it check-everything-connected in our emails; old habits die hard, I suppose. ;) builtin/receive-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)