diff mbox series

drm/i915: Log HWS seqno consistently

Message ID 20180926111217.24130-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Log HWS seqno consistently | expand

Commit Message

Tvrtko Ursulin Sept. 26, 2018, 11:12 a.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

We mix hexa- and decimal which is confusing when reading the logs. So make
the single odd one out instance decimal for consistency.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
Later we can consider whether we should move them all to unsigned, or hex,
etc..
---
 drivers/gpu/drm/i915/intel_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson Sept. 26, 2018, 11:17 a.m. UTC | #1 
Quoting Tvrtko Ursulin (2018-09-26 12:12:17)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> We mix hexa- and decimal which is confusing when reading the logs. So make
> the single odd one out instance decimal for consistency.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> Later we can consider whether we should move them all to unsigned, or hex,
> etc..
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 4b28225320ff..ad93aa4b0a6e 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1904,7 +1904,7 @@ static void execlists_reset(struct intel_engine_cs *engine,
>         unsigned long flags;
>         u32 *regs;
>  
> -       GEM_TRACE("%s request global=%x, current=%d\n",
> +       GEM_TRACE("%s request global=%d, current=%d\n",
>                   engine->name, request ? request->global_seqno : 0,
>                   intel_engine_get_seqno(engine));
>  

One more in intel_ringbuffer.c
drivers/gpu/drm/i915/intel_ringbuffer.c:        GEM_TRACE("%s seqno=%x\n", engine->name, rq ? rq->global_seqno : 0);
-Chris
Tvrtko Ursulin Sept. 27, 2018, 10:28 a.m. UTC | #2 
On 26/09/2018 16:49, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Log HWS seqno consistently (rev2)
> URL   : https://patchwork.freedesktop.org/series/50193/
> State : success
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_4883 -> Patchwork_10286 =
> 
> == Summary - WARNING ==
> 
>    Minor unknown changes coming with Patchwork_10286 need to be verified
>    manually.
>    
>    If you think the reported changes have nothing to do with the changes
>    introduced in Patchwork_10286, please notify your bug team to allow them
>    to document this new failure mode, which will reduce false positives in CI.
> 
>    External URL: https://patchwork.freedesktop.org/api/1.0/series/50193/revisions/2/mbox/
> 
> == Possible new issues ==
> 
>    Here are the unknown changes that may have been introduced in Patchwork_10286:
> 
>    === IGT changes ===
> 
>      ==== Warnings ====
> 
>      igt@pm_rpm@module-reload:
>        fi-hsw-4770r:       PASS -> SKIP
> 
>      
> == Known issues ==
> 
>    Here are the changes found in Patchwork_10286 that come from known issues:
> 
>    === IGT changes ===
> 
>      ==== Issues hit ====
> 
>      igt@debugfs_test@read_all_entries:
>        fi-icl-u:           PASS -> DMESG-WARN (fdo#107724, fdo#108070)
> 
>      igt@drv_getparams_basic@basic-eu-total:
>        fi-icl-u:           PASS -> DMESG-WARN (fdo#107724)
> 
>      igt@drv_module_reload@basic-reload-inject:
>        fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107924, fdo#107425)
> 
>      igt@gem_exec_suspend@basic-s3:
>        fi-bdw-samus:       PASS -> INCOMPLETE (fdo#107773)
>        fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)
> 
>      igt@kms_frontbuffer_tracking@basic:
>        fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)
> 
>      
>      ==== Possible fixes ====
> 
>      igt@kms_psr@primary_page_flip:
>        fi-cfl-s3:          FAIL (fdo#107336) -> PASS
>        fi-kbl-r:           FAIL (fdo#107336) -> PASS
> 
>      
>    fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
>    fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
>    fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
>    fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
>    fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
>    fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
>    fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
>    fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070
> 
> 
> == Participating hosts (47 -> 42) ==
> 
>    Missing    (5): fi-bsw-cyan fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-hsw-4200u
> 
> 
> == Build changes ==
> 
>      * Linux: CI_DRM_4883 -> Patchwork_10286
> 
>    CI_DRM_4883: fe61f770c6bb80e924efb5c822440d265df3dc7f @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_4650: a6e21812d100dce68450727e79fc09e0c0033683 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_10286: c2f0ae53ffd34dab3ec832fbaea4ba5ba9fbcbd5 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> c2f0ae53ffd3 drm/i915: Log HWS seqno consistently

Pushed, thanks for the review!

Regards,

Tvrtko
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 4b28225320ff..ad93aa4b0a6e 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1904,7 +1904,7 @@  static void execlists_reset(struct intel_engine_cs *engine,
 	unsigned long flags;
 	u32 *regs;
 
-	GEM_TRACE("%s request global=%x, current=%d\n",
+	GEM_TRACE("%s request global=%d, current=%d\n",
 		  engine->name, request ? request->global_seqno : 0,
 		  intel_engine_get_seqno(engine));