| Message ID | 20180924114819.12637-1-mika.kuoppala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915/gen9: WaRsClearFWBitsAtFLR is for all gen9 | expand |
Quoting Mika Kuoppala (2018-09-24 12:48:18) > Requirement to clear forcewake bits is for all gen9. Update > the wa comment to reflect that. I trust the change in wa name is accurate. > Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
Chris Wilson <chris@chris-wilson.co.uk> writes: > Quoting Mika Kuoppala (2018-09-24 12:48:18) >> Requirement to clear forcewake bits is for all gen9. Update >> the wa comment to reflect that. > > I trust the change in wa name is accurate. It is consistent now and matches the databse, and it has been changed all the way back to bdw. Why it was changed? I rather just skip right ahead to the acceptance. > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Thanks, -Mika
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 3ad302c66254..9f11c51baae8 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -1403,7 +1403,7 @@ static void intel_uncore_fw_domains_init(struct drm_i915_private *dev_priv) dev_priv->uncore.fw_set = FORCEWAKE_KERNEL; dev_priv->uncore.fw_clear = 0; } else { - /* WaRsClearFWBitsAtReset:bdw,skl */ + /* WaRsClearFWBitsAtFLR:bdw,skl,bxt,kbl,glk,cfl */ dev_priv->uncore.fw_reset = _MASKED_BIT_DISABLE(0xffff); dev_priv->uncore.fw_set = _MASKED_BIT_ENABLE(FORCEWAKE_KERNEL); dev_priv->uncore.fw_clear = _MASKED_BIT_DISABLE(FORCEWAKE_KERNEL);
Requirement to clear forcewake bits is for all gen9. Update the wa comment to reflect that. Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> --- drivers/gpu/drm/i915/intel_uncore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)