| Message ID | 1537597886-136734-1-git-send-email-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] USB: core: remove set but not used variable 'udev' | expand |
On Sat, 22 Sep 2018, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > drivers/usb/core/driver.c:513:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/usb/core/driver.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c > index a1f225f..5356438 100644 > --- a/drivers/usb/core/driver.c > +++ b/drivers/usb/core/driver.c > @@ -510,7 +510,6 @@ int usb_driver_claim_interface(struct usb_driver *driver, > struct usb_interface *iface, void *priv) > { > struct device *dev; > - struct usb_device *udev; > int retval = 0; > > if (!iface) > @@ -524,8 +523,6 @@ int usb_driver_claim_interface(struct usb_driver *driver, > if (!iface->authorized) > return -ENODEV; > > - udev = interface_to_usbdev(iface); > - > dev->driver = &driver->drvwrap.driver; > usb_set_intfdata(iface, priv); > iface->needs_binding = 0; Acked-by: Alan Stern <stern@rowland.harvard.edu>
On Sat, Sep 22, 2018 at 06:31:26AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > drivers/usb/core/driver.c:513:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Acked-by: Alan Stern <stern@rowland.harvard.edu> > --- > drivers/usb/core/driver.c | 3 --- > 1 file changed, 3 deletions(-) This patch breaks the build, which is not ok :(
On Fri, 28 Sep 2018, Greg Kroah-Hartman wrote: > On Sat, Sep 22, 2018 at 06:31:26AM +0000, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > > drivers/usb/core/driver.c:513:21: warning: > > variable 'udev' set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > --- > > drivers/usb/core/driver.c | 3 --- > > 1 file changed, 3 deletions(-) > > This patch breaks the build, which is not ok :( Are you sure you applied it to the right branch? It requires commit c183813fcee44a24 ("USB: remove LPM management from usb_driver_claim_interface()"). Probably the tags should mention this. Alan Stern
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index a1f225f..5356438 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -510,7 +510,6 @@ int usb_driver_claim_interface(struct usb_driver *driver, struct usb_interface *iface, void *priv) { struct device *dev; - struct usb_device *udev; int retval = 0; if (!iface) @@ -524,8 +523,6 @@ int usb_driver_claim_interface(struct usb_driver *driver, if (!iface->authorized) return -ENODEV; - udev = interface_to_usbdev(iface); - dev->driver = &driver->drvwrap.driver; usb_set_intfdata(iface, priv); iface->needs_binding = 0;
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': drivers/usb/core/driver.c:513:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/usb/core/driver.c | 3 --- 1 file changed, 3 deletions(-)