| Message ID | 20180911232025.4909-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: timb_dma: Use proper enum in td_prep_slave_sg | expand |
On Tue, Sep 11, 2018 at 4:20 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns when implicitly converting from one enumerated type to > another. Avoid this by using the equivalent value from the expected > type. > > drivers/dma/timb_dma.c:548:27: warning: implicit conversion from > enumeration type 'enum dma_transfer_direction' to different enumeration > type 'enum dma_data_direction' [-Wenum-conversion] > td_desc->desc_list_len, DMA_MEM_TO_DEV); > ^~~~~~~~~~~~~~ > 1 warning generated. > > Reported-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/dma/timb_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c > index 395c698edb4d..fc0f9c8766a8 100644 > --- a/drivers/dma/timb_dma.c > +++ b/drivers/dma/timb_dma.c > @@ -545,7 +545,7 @@ static struct dma_async_tx_descriptor *td_prep_slave_sg(struct dma_chan *chan, > } > > dma_sync_single_for_device(chan2dmadev(chan), td_desc->txd.phys, > - td_desc->desc_list_len, DMA_MEM_TO_DEV); > + td_desc->desc_list_len, DMA_TO_DEVICE); Looks like DMA_MEM_TO_DEV and DMA_TO_DEVICE happen to have the same value (today) so no functional change. And dma_sync_single_for_device is defined to take the `enum dma_data_direction` which `DMA_TO_DEVICE` is an enumeration of. Thanks for the patch Nathan. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > return &td_desc->txd; > } > -- > 2.18.0 >
On 11-09-18, 16:20, Nathan Chancellor wrote: > Clang warns when implicitly converting from one enumerated type to > another. Avoid this by using the equivalent value from the expected > type. > > drivers/dma/timb_dma.c:548:27: warning: implicit conversion from > enumeration type 'enum dma_transfer_direction' to different enumeration > type 'enum dma_data_direction' [-Wenum-conversion] > td_desc->desc_list_len, DMA_MEM_TO_DEV); > ^~~~~~~~~~~~~~ > 1 warning generated. Applied, thanks
diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c index 395c698edb4d..fc0f9c8766a8 100644 --- a/drivers/dma/timb_dma.c +++ b/drivers/dma/timb_dma.c @@ -545,7 +545,7 @@ static struct dma_async_tx_descriptor *td_prep_slave_sg(struct dma_chan *chan, } dma_sync_single_for_device(chan2dmadev(chan), td_desc->txd.phys, - td_desc->desc_list_len, DMA_MEM_TO_DEV); + td_desc->desc_list_len, DMA_TO_DEVICE); return &td_desc->txd; }
Clang warns when implicitly converting from one enumerated type to another. Avoid this by using the equivalent value from the expected type. drivers/dma/timb_dma.c:548:27: warning: implicit conversion from enumeration type 'enum dma_transfer_direction' to different enumeration type 'enum dma_data_direction' [-Wenum-conversion] td_desc->desc_list_len, DMA_MEM_TO_DEV); ^~~~~~~~~~~~~~ 1 warning generated. Reported-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/dma/timb_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)